Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE_TEMPLATE for #846 #847

Merged
merged 1 commit into from
Sep 5, 2016
Merged

ISSUE_TEMPLATE for #846 #847

merged 1 commit into from
Sep 5, 2016

Conversation

cchan
Copy link

@cchan cchan commented Aug 9, 2016

MICRO ISSUE TRACKER: portability problems in suggested commands

  • cmd /c ver does not work in Git Bash because cmd is not in PATH
  • cat /etc/install-options.txt does not work in CMD because /etc isn't a real thing on Windows.
commit 3c8601c3b512ad97d0e420cef5b34b28425dae38
Author: Clive Chan <[email protected]>
Date:   Fri Aug 12 13:46:25 2016 -0400

    Add detail to ISSUE_TEMPLATE setup questions

    With the addition of the architecture (x86/x86_64) to git --version
    --build-options, it's good to add that to the Git version question.

    On the Windows version question, prompted for "Vista, 7, 8, 10? to
    indicate exactly what we're talking about. Also added `cmd /c ver as a
    command to run to get the Windows version, but it's not portable yet so
    that needs fixing before merging.

    On the installation options question, added `cat /etc/install-options.txt`
    to provide more information. This also is not portable and also needs to
    be fixed.

    Relevant Links:
    This is part of https://github.com/git-for-windows/git/pull/847.
    The git --version --build-options change discussion is at
    https://github.com/git-for-windows/git/issues/846

    Signed-off-by: Clive Chan <[email protected]>

@dscho
Copy link
Member

dscho commented Aug 12, 2016

While I like the direction this is going, I cannot merge as-is:

  • we really need your Sign-off
  • the commit message should be self-contained, with links for context and further reading at the end
  • the "Which version of Windows are you using?" section should probably refer the user to cmd /c ver
  • while we are touching the issue template, we should probably ask for the contents of the file C:\Program Files\Git\etc\install-options.txt instead of asking what options were specified in the installer

@cchan
Copy link
Author

cchan commented Aug 12, 2016

Alright, I'll fix those.

@cchan
Copy link
Author

cchan commented Aug 12, 2016

What about systeminfo | findstr /i /r /c:"^os version" /c:"^system type"? Too complicated? 😝

Also, interestingly, cmd isn't in my bash PATH.

@cchan
Copy link
Author

cchan commented Aug 12, 2016

and one more thing - C:\Program Files\Git\etc\install-options.txt doesn't exist for me; my install dir is local so it's C:\Users\Clive\AppData\Local\Programs\Git\etc\install-options.txt. I don't have a GIT_DIR variable anywhere, so I'm not sure how to do this portably.

With the addition of the architecture (x86/x86_64) to git --version
--build-options, it's good to add that to the Git version question.

On the Windows version question, prompted for "Vista, 7, 8, 10? to
indicate exactly what we're talking about. Also added `cmd.exe /c ver` as
a command to run to get the Windows version, and `cat /etc/install-options.txt`
and several alternative CMD commands to provide information on build options.

Relevant Links:
This is part of git-for-windows#847.
The git --version --build-options change discussion is at
git-for-windows#846

Signed-off-by: Clive Chan <[email protected]>
@cchan
Copy link
Author

cchan commented Sep 4, 2016

@dscho is this good?

@dscho dscho merged commit 732a511 into git-for-windows:master Sep 5, 2016
@dscho
Copy link
Member

dscho commented Sep 5, 2016

Yes, it is! Thanks!

dscho pushed a commit that referenced this pull request Sep 6, 2016
With the addition of the architecture (x86/x86_64) to git --version
--build-options, it's good to add that to the Git version question.

On the Windows version question, prompted for "Vista, 7, 8, 10? to
indicate exactly what we're talking about. Also added `cmd.exe /c ver` as
a command to run to get the Windows version, and `cat /etc/install-options.txt`
and several alternative CMD commands to provide information on build options.

Relevant Links:
This is part of #847.
The git --version --build-options change discussion is at
#846

Signed-off-by: Clive Chan <[email protected]>
dscho added a commit that referenced this pull request Sep 6, 2016
dscho pushed a commit that referenced this pull request Sep 6, 2016
With the addition of the architecture (x86/x86_64) to git --version
--build-options, it's good to add that to the Git version question.

On the Windows version question, prompted for "Vista, 7, 8, 10? to
indicate exactly what we're talking about. Also added `cmd.exe /c ver` as
a command to run to get the Windows version, and `cat /etc/install-options.txt`
and several alternative CMD commands to provide information on build options.

Relevant Links:
This is part of #847.
The git --version --build-options change discussion is at
#846

Signed-off-by: Clive Chan <[email protected]>
dscho added a commit that referenced this pull request Sep 6, 2016
dscho pushed a commit that referenced this pull request Sep 10, 2016
With the addition of the architecture (x86/x86_64) to git --version
--build-options, it's good to add that to the Git version question.

On the Windows version question, prompted for "Vista, 7, 8, 10? to
indicate exactly what we're talking about. Also added `cmd.exe /c ver` as
a command to run to get the Windows version, and `cat /etc/install-options.txt`
and several alternative CMD commands to provide information on build options.

Relevant Links:
This is part of #847.
The git --version --build-options change discussion is at
#846

Signed-off-by: Clive Chan <[email protected]>
dscho added a commit that referenced this pull request Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants