nanosecond file times for v2.5.3 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstat() is the only stat-related CRT function for which we don't have a full replacement yet (and thus the only reason to stick with MSVCRT's 'struct stat' definition). Fully implement fstat(), in preparation of implementing a POSIX 2013 compatible 'struct stat' with nanosecond-precision file times. Signed-off-by: Karsten Blees <[email protected]>
We no longer use any of MSVCRT's stat-functions, so there's no need to stick to a CRT-compatible 'struct stat' either. Define and use our own POSIX-2013-compatible 'struct stat' with nanosecond- precision file times. Note: Due to performance issues when using git variants with different file time resolutions, this patch does *not* yet enable nanosecond precision in the Makefile (use 'make USE_NSEC=1'). Signed-off-by: Karsten Blees <[email protected]>
|
Nice! (Of course, it is not so nice that there are still racy things going on...). I am thinking about merging this and play it by ear, depending on the discussion on the mailing list. @kblees are you okay with that? |
Of course, go ahead. |
dscho
added a commit
that referenced
this pull request
Sep 28, 2015
nanosecond file times for v2.5.3
|
Thanks! |
dscho
added a commit
that referenced
this pull request
Sep 29, 2015
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Oct 19, 2015
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Dec 11, 2015
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Jan 28, 2016
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Feb 23, 2016
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Mar 15, 2016
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Mar 18, 2016
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Mar 29, 2016
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Apr 30, 2016
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
May 20, 2016
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Jun 14, 2016
nanosecond file times for v2.5.3
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 5, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 10, 2018
nanosecond file times for v2.5.3
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 11, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 24, 2018
nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Oct 10, 2018
nanosecond file times for v2.5.3
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 12, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Oct 12, 2018
nanosecond file times for v2.5.3
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 19, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 19, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 30, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 30, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 19, 2018
…-times-v2.5.3 nanosecond file times for v2.5.3
dscho
added a commit
that referenced
this pull request
Nov 21, 2018
nanosecond file times for v2.5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the nanosecond file time patches, rebased to v2.5.3.
While testing, I found a few nasty issues when using git variants with different file time resolutions on the same repository (e.g. Git for Windows and JGit/EGit) [1]. This is why the second patch does not currently enable USE_NSEC in the Makefile (use
make USE_NSEC=1to build with nanosecond support).[1] http://article.gmane.org/gmane.comp.version-control.git/278683