Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipe() ignored errors on filedes[1] #306

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Conversation

jfmc
Copy link

@jfmc jfmc commented Aug 23, 2015

No description provided.

@dscho
Copy link
Member

dscho commented Aug 25, 2015

Ping?

@dscho dscho closed this Aug 25, 2015
@dscho dscho reopened this Aug 25, 2015
The code to open and test the second end of the pipe clearly imitates
the code for the first end. A little too closely, though... Let's fix
the obvious copy-edit bug.

Signed-off-by: Jose F. Morales <[email protected]>
dscho added a commit that referenced this pull request Aug 25, 2015
pipe() ignored errors on filedes[1]
@dscho dscho merged commit 5e906e9 into git-for-windows:master Aug 25, 2015
@dscho
Copy link
Member

dscho commented Aug 25, 2015

Awesome.

@jfmc jfmc deleted the patch-1 branch August 25, 2015 14:43
jeffhostetler pushed a commit to jeffhostetler/git that referenced this pull request May 14, 2021
…b check

This check verifies that the ODB matches what we supplied, but there are
some subtleties around Windows path names that can cause inexact matches
to be logically the same. Since this check is really intended only for
debugging and development purposes, let's remove it for now as a quick
workaround.

This was originally part of git-for-windows#304, as I hit it more often in that effort. However,
this was hit during the Scalar release process, so I'll need to generate new
installers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants