fixup! mingw: ensure valid CTYPE #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Originally, the intention was to set `LC_CTYPE=C.UTF-8`, but that
elicited some bug report. Sadly, the to-be-fixed-up commit's message
does not record this properly. Having searched for a while, it would
appear to this developer that the issue was ConEmu, as mentioned here:
https://groups.google.com/g/git-for-windows/c/9_abrdlqi48/m/S9pJE56ZDgAJ
This was a long time ago, and re-testing with a current ConEmu failed to
reproduce the original issue.
So let's just go ahead and set `LC_CTYPE=C.UTF-8` (unless something else
was _already_ specified via `LANG`, `LC_ALL` or `LC_CTYPE`).
This fixes git-for-windows#2802
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
lctype-should-adapt-to-console-code-page
branch
from
3ea01d6 to
8a1fdd6
Compare
|
Verified by @fcharlie |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Sep 29, 2020
Non-ASCII output of paged Git commands [is now rendered correctly in Windows Terminal](git-for-windows/git#2834). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2802. It simply assumes that the console output code page is UTF-8.
This PR may very well also address #1087 and #1682, at long last.