config.c: fix writing config files on Windows network shares #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming to an existing file doesn't work on Windows network shares if the target is open. munmap() the old config file before commit_lock_file. Signed-off-by: Karsten Blees <[email protected]>
|
Whoops, I saw the mail before the Pull Request, sorry. "Merged" by applying with a sign-off... |
1 task
garimasi514
pushed a commit
to garimasi514/git
that referenced
this pull request
Jan 6, 2020
…-lock-pack-dir gvfs-helper: better support for concurrent packfile fetches
garimasi514
pushed a commit
to garimasi514/git
that referenced
this pull request
Jan 6, 2020
…ing temp files When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to git-for-windows#229.
jeffhostetler
added a commit
to jeffhostetler/git
that referenced
this pull request
Apr 11, 2020
…-lock-pack-dir gvfs-helper: better support for concurrent packfile fetches
jeffhostetler
pushed a commit
to jeffhostetler/git
that referenced
this pull request
Apr 11, 2020
…ing temp files When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to git-for-windows#229.
jeffhostetler
added a commit
to jeffhostetler/git
that referenced
this pull request
Apr 13, 2020
…-lock-pack-dir gvfs-helper: better support for concurrent packfile fetches
jeffhostetler
pushed a commit
to jeffhostetler/git
that referenced
this pull request
Apr 13, 2020
…ing temp files When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to git-for-windows#229.
jeffhostetler
pushed a commit
to jeffhostetler/git
that referenced
this pull request
Jun 3, 2020
Includes these pull requests: git-for-windows#227 git-for-windows#228 git-for-windows#229 git-for-windows#231 git-for-windows#240 Signed-off-by: Derrick Stolee <[email protected]>
jeffhostetler
pushed a commit
to jeffhostetler/git
that referenced
this pull request
May 14, 2021
Includes these pull requests: git-for-windows#227 git-for-windows#228 git-for-windows#229 git-for-windows#231 git-for-windows#240 Signed-off-by: Derrick Stolee <[email protected]>
jeffhostetler
pushed a commit
to jeffhostetler/git
that referenced
this pull request
Jun 21, 2021
Includes these pull requests: git-for-windows#227 git-for-windows#228 git-for-windows#229 git-for-windows#231 git-for-windows#240 Signed-off-by: Derrick Stolee <[email protected]>
jeffhostetler
pushed a commit
to jeffhostetler/git
that referenced
this pull request
Aug 18, 2021
Includes these pull requests: git-for-windows#227 git-for-windows#228 git-for-windows#229 git-for-windows#231 git-for-windows#240 Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham
pushed a commit
to mjcheetham/git
that referenced
this pull request
Jun 16, 2022
Includes these pull requests: git-for-windows#227 git-for-windows#228 git-for-windows#229 git-for-windows#231 git-for-windows#240 Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham
pushed a commit
to mjcheetham/git
that referenced
this pull request
Jul 23, 2024
Includes these pull requests: git-for-windows#227 git-for-windows#228 git-for-windows#229 git-for-windows#231 git-for-windows#240 Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham
pushed a commit
to mjcheetham/git
that referenced
this pull request
Jan 20, 2025
Includes these pull requests: git-for-windows#227 git-for-windows#228 git-for-windows#229 git-for-windows#231 git-for-windows#240 Signed-off-by: Derrick Stolee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #226
Caused by 3a1b312 "config.c: fix mmap leak when writing config" in 2.4.5.
I've sent the fix upstream as well.