Installer freezes when testing custom Atom editor command while Atom is already open

[schtandard]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

  $ git --version --build-options
  git version 2.31.1.windows.1
  cpu: x86_64
  built from commit: c5f0be26a7e3846e3b6268d1c6c4800d838c6bbb
  sizeof-long: 4
  sizeof-size_t: 8
  shell-path: /bin/sh
  feature: fsmonitor--daemon
  

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

  $ cmd.exe /c ver
  
  Microsoft Windows [Version 10.0.19042.868]
  

• What options did you set as part of the installation? Or did you choose the
  defaults?

  $ cat /etc/install-options.txt
  
  Editor Option: Atom
  Custom Editor Path:
  Default Branch Option:
  Path Option: Cmd
  SSH Option: OpenSSH
  Tortoise Option: false
  CURL Option: OpenSSL
  CRLF Option: CRLFAlways
  Bash Terminal Option: MinTTY
  Git Pull Behavior Option: Merge
  Use Credential Manager: Core
  Performance Tweaks FSCache: Enabled
  Enable Symlinks: Disabled
  Enable Pseudo Console Support: Disabled
  

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

  Nope.

Details

• How did I produce the error?

  • Open Atom.
  • Run the Git for Windows installer
  • In the step Choosing the default editor used by Git, select Select other editor as Git's default editor.
  • In the text field below, enter atom --wait --new-window.
  • Click Test Custom Editor.

• What happened?

  • A new atom window opened, as expected.
  • After closing it, the installer is frozen.
  • After closing the originally opened Atom window, the installer is still frozen.
  • The only way I could find to get rid of the installer window was to terminate its process by force.

[dscho]

Hmm. This is the code that runs that test: https://github.com/git-for-windows/build-extra/blob/7d6d0dfbfbacb55ad7af8d76a7c88f85db9f80bf/installer/install.iss#L1505-L1560

From what you say, it is probably stuck here: https://github.com/git-for-windows/build-extra/blob/7d6d0dfbfbacb55ad7af8d76a7c88f85db9f80bf/installer/install.iss#L1529

[dscho]

Oh... would you have a chance to test out something? I have the hunch that calling the ShellExec() function is at fault here (because Atom is installed user-wide, we should execute it as the original user, not as administrator, i.e. use ShellExecAsOriginalUser().

This is how you can help by testing it:

1. install Git for Windows' SDK,
2. sdk cd installer,
3. edit install.iss to replace ShellExec() as indicated above
4. build a new installer via sdk build installer
5. verify that that installer works as expected?
6. open a PR?

[schtandard]

That seems to do the trick and I created a pull request.

I assume this won't lead to problems with editors that are installed system-wide? I have no experience here.

[dscho]

Fixed via git-for-windows/build-extra#334