-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Git Bash
pinnable
#263
Comments
Hmm. It seems that I fail to set the It looks as if a hacked up |
Wait a minute. I think it should be enough to set an app id for the git-wrapper. You can just provide the app id that |
You can confirm this theory following the steps outlined below. first, change your registry so that you edit the
Now open the Git for windows shortcut in the taskbar and set the id in the details pane to Then add the following to your And viola: it just works. |
So I think we can avoid patching |
Nice! This would not really help with portable Git, though, correct? |
Sure. Why not? If |
Oh, wait, the registry entry is not even required if we set the AppID in the Git wrapper as well as the Git Bash... I get it now! |
Right its just a way to set an id for a shortcut ig the exe provides none. |
I really like the idea. I'm on it. |
Sadly, it is not as easy 😞... In my tests, setting the app ID via I then continued to work on implementing support for the Unfortunately, it also did not work at first (even if it had worked in some tests I did yesterday). Hours later, turns out that the reason is well explained in the MSDN page:
So the only way to get it to work was by setting the combination of ID, RelaunchCommand and RelaunchDisplayNameResource together. The important part is that I have to set an ID explicitly. Otherwise, the display name is respected but not the relaunch command. This got me curious, though, and I tested whether things start to work properly if I tell Alas, this works! Restarting the Git Bash from a pinned icon works if (It might be a quirk just of Windows Server 2012 R2, on which I do all my testing and development, meaning that we have to patch So at the moment, I have patches for |
See git-for-windows/MSYS2-packages@master...dscho:pinning-mintty for the current state of things. Still needs serious testing. |
The |
@nalla thanks for confirming! FYI I opened a PR for mintty: mintty/mintty#471 |
Update: I now have topic branches in three (!) repositories that work together to address this ticket:
The changes for Long day. |
Part 1/3 of fixing git-for-windows/git#263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 3/3 of fixing git-for-windows/git#263 Signed-off-by: Johannes Schindelin <[email protected]>
With these three merges, this ticket is finally addressed. |
Did this (awesome!) work make the 2.5.0 release? I've updated and I still appear to have the 'jumbled' stacks issue (for git-bash.exe incidentally, git-cmd.exe appears to work as 'expected') |
It made it into the release. You most likely have a stale Once you unpin, delete that |
Part 2/3 of fixing git-for-windows#263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing git-for-windows#263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
Part 2/3 of fixing #263 Signed-off-by: Johannes Schindelin <[email protected]>
We found a user who had set "core.gvfs = false" in their global config. This should not have been necessary, but it also should not have caused a problem. However, it did. The reason is that gvfs_load_config_value() is called from config.c when reading config key/value pairs from all the config files. The local config should override the global config, and this is done by config.c reading the global config first then reading the local config. However, our logic only allowed writing the core_gvfs variable once. Put the guards against multiple assignments of core_gvfs into gvfs_config_is_set() instead, because that will fix the problem _and_ keep multiple calls to gvfs_config_is_set() from slowing down.
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: git-for-windows#85 git-for-windows#89 git-for-windows#91 git-for-windows#98 git-for-windows#243 git-for-windows#263 Signed-off-by: Derrick Stolee <[email protected]>
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: git-for-windows#85 git-for-windows#89 git-for-windows#91 git-for-windows#98 git-for-windows#243 git-for-windows#263 Signed-off-by: Derrick Stolee <[email protected]>
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: git-for-windows#85 git-for-windows#89 git-for-windows#91 git-for-windows#98 git-for-windows#243 git-for-windows#263 Signed-off-by: Derrick Stolee <[email protected]>
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: git-for-windows#85 git-for-windows#89 git-for-windows#91 git-for-windows#98 git-for-windows#243 git-for-windows#263 Signed-off-by: Derrick Stolee <[email protected]>
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: git-for-windows#85 git-for-windows#89 git-for-windows#91 git-for-windows#98 git-for-windows#243 git-for-windows#263 Signed-off-by: Derrick Stolee <[email protected]>
Most of these were done in private before microsoft/git. However, the following pull requests modified the core feature: git-for-windows#85 git-for-windows#89 git-for-windows#91 git-for-windows#98 git-for-windows#243 git-for-windows#263 Signed-off-by: Derrick Stolee <[email protected]>
After starting Git Bash, the context menu in the Task Bar icon allows to pin the program. However, starting Git Bash that way does not start the same program but instead launches
mintty.exe
(andbash.exe
is launched in there, but without the--login
flag and without theMSYSTEM
environment variable set appropriately).Investigate whether this is fixed by setting the
System.AppUserModel.RelaunchCommand
property from the Git wrapper might help (as hinted in this blog). (I hinted at that already here but that information was ignored there.)The text was updated successfully, but these errors were encountered: