Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid executable path error for git version :: mingit bundled with vsts-agent :: RAM Disk #2493

Closed
1 task
VenumadhavDuriseti opened this issue Jan 27, 2020 · 11 comments
Milestone

Comments

@VenumadhavDuriseti
Copy link

Moving this issue to gitforwindows

  • I was not able to find an open or closed issue matching what I'm seeing
  • Kind of similar issue

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
    64 bit, that is packed with vsts-agent-2.164.6
$ git --version --build-options

Invalid executable path:
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
    10.0.14393 x64

Issue summary

I set up RAM Disk drive (X:) on my machine, using imdisk (and osfmount etc) and downloaded the agent binaries from 2.164.6 and tried running git version, it fails saying "Invalid executable path"

image

@dscho
Copy link
Member

dscho commented Jan 27, 2020

@VenumadhavDuriseti if you download the latest snapshot's Portable Git and extract it onto that RAM disk, does that Git work?

@VenumadhavDuriseti
Copy link
Author

I tried the Portable git and mingit, it gives the same error:
image

@Ajaja
Copy link

Ajaja commented Jan 28, 2020

I have the same problem with ImDisk RAM drives.

@dscho
Copy link
Member

dscho commented Jan 29, 2020

I tried the Portable git and mingit, it gives the same error:

@VenumadhavDuriseti You delight in keeping this report the opposite of verbose, or for that matter, complete, don't you?

Like, is this CMD or Git CMD? Can you execute any .exe you copy to the RAM drive?

It is pretty frustrating to have to work with that little information, too little, in fact, to make any sense of your bug report. Essentially, you try to force me to do way more work on my side than I actually have to. Please be more considerate.

@Ajaja if you could put in a bit more effort to add missing information to this ticket, that would also be more than welcome.

@dscho
Copy link
Member

dscho commented Jan 29, 2020

Oh well, thanks to #1405 (comment), I was able to set this up quickly.

@dscho
Copy link
Member

dscho commented Jan 29, 2020

quickly.

Where "quickly" translates to "30 minutes that I could not take care of issues that affect more than a mere dozen Git for Windows users"... 😞

dscho added a commit to git-for-windows/MINGW-packages that referenced this issue Jan 29, 2020
When `GetFinalPathNameByHandleW()` returns 0, it means that it failed.
In this case, we want fall back to using the originally-provided
executable path, even if it might contain unresolved symbolic links.

However, we did not fall back to using this path when that function call
failed, except when it failed in a way that indicates that the resulting
path would be too long.

The symptom of this bug is a rather obscure:

	Invalid executable path:

This commit addresses that, fixing
git-for-windows/git#2493

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member

dscho commented Jan 29, 2020

The next snapshot will have this fixed.

@dscho dscho closed this as completed Jan 29, 2020
@dscho dscho added this to the Next release milestone Jan 29, 2020
dscho added a commit to git-for-windows/build-extra that referenced this issue Jan 29, 2020
Portable Git [can now be run from a RAM
disk](git-for-windows/git#2493), too.

Signed-off-by: Johannes Schindelin <[email protected]>
@VenumadhavDuriseti
Copy link
Author

Thank you @dscho for having this fixed, and apologies for not being clear on description.

Like, is this CMD or Git CMD? Can you execute any .exe you copy to the RAM drive?

Just leaving information here, it is a normal cmd. And yes I can run any exe I copy to RAM Drive.

@dscho
Copy link
Member

dscho commented Jan 31, 2020

Could you verify that the latest snapshot fixes the issue?

@VenumadhavDuriseti
Copy link
Author

Seems like it works, thank you @dscho
image

@dscho
Copy link
Member

dscho commented Feb 1, 2020

Thank you for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants