-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid executable path error for git version :: mingit bundled with vsts-agent :: RAM Disk #2493
Comments
@VenumadhavDuriseti if you download the latest snapshot's Portable Git and extract it onto that RAM disk, does that Git work? |
I have the same problem with ImDisk RAM drives. |
@VenumadhavDuriseti You delight in keeping this report the opposite of verbose, or for that matter, complete, don't you? Like, is this CMD or Git CMD? Can you execute any It is pretty frustrating to have to work with that little information, too little, in fact, to make any sense of your bug report. Essentially, you try to force me to do way more work on my side than I actually have to. Please be more considerate. @Ajaja if you could put in a bit more effort to add missing information to this ticket, that would also be more than welcome. |
Oh well, thanks to #1405 (comment), I was able to set this up quickly. |
Where "quickly" translates to "30 minutes that I could not take care of issues that affect more than a mere dozen Git for Windows users"... 😞 |
When `GetFinalPathNameByHandleW()` returns 0, it means that it failed. In this case, we want fall back to using the originally-provided executable path, even if it might contain unresolved symbolic links. However, we did not fall back to using this path when that function call failed, except when it failed in a way that indicates that the resulting path would be too long. The symptom of this bug is a rather obscure: Invalid executable path: This commit addresses that, fixing git-for-windows/git#2493 Signed-off-by: Johannes Schindelin <[email protected]>
The next snapshot will have this fixed. |
Portable Git [can now be run from a RAM disk](git-for-windows/git#2493), too. Signed-off-by: Johannes Schindelin <[email protected]>
Thank you @dscho for having this fixed, and apologies for not being clear on description.
Just leaving information here, it is a normal cmd. And yes I can run any exe I copy to RAM Drive. |
Could you verify that the latest snapshot fixes the issue? |
Seems like it works, thank you @dscho |
Thank you for confirming! |
Moving this issue to gitforwindows
Setup
64 bit, that is packed with vsts-agent-2.164.6
10.0.14393 x64
Issue summary
I set up RAM Disk drive (X:) on my machine, using imdisk (and osfmount etc) and downloaded the agent binaries from 2.164.6 and tried running git version, it fails saying "Invalid executable path"
The text was updated successfully, but these errors were encountered: