Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi has become completely unusable. #223

Closed
sprintr opened this issue Jun 23, 2015 · 5 comments
Closed

vi has become completely unusable. #223

sprintr opened this issue Jun 23, 2015 · 5 comments
Labels

Comments

@sprintr
Copy link

sprintr commented Jun 23, 2015

Using v2.4.3 and v2.4.4, vi has become completely unusable. It has also lost its syntax highlighting. v2.4.2 worked fine with vi.

git version 2.4.2 windows 1
git version 2 4 2 windows 1

git version 2.4.4 windows 1
git version 2 4 4 windows 2

@linquize
Copy link

where is syntax highlighting in 2.4.4.1?

@sprintr
Copy link
Author

sprintr commented Jun 24, 2015

There is no syntax highlighting in 2.4.4 @linquize

@nalla
Copy link

nalla commented Jun 24, 2015

What is your output of the following calls?

cat /etc/vimrc
cat ~/.vimrc

@dscho dscho added the invalid label Jun 24, 2015
@dscho
Copy link
Member

dscho commented Jun 24, 2015

There is no syntax highlighting in 2.4.4 @linquize

Uhm.

Just to be sure, here is the information that I would really like in essentially every bug report because it is really relevant:

  • This is Git Bash,
  • as installed via the Git installer (release candidate 3)
  • 64-bit Windows 2012

And editing a C file just works:

vi-syntax-highlighting-works

Well, maybe it is just PHP highlighting? Nope, that works, too:

even-php-highlighting-works

Therefore it is not a problem of Git for Windows per se, but instead an issue in your particular setup. @nalla was nice enough to suggest pointers how to start hunting. I would also offer this pointer:

ls /usr/share/vim/vim74/syntax/

(which takes quite a while here and lists 583 files that are used by vim to provide 583 different types of syntax highlighting.)

I would also like to challenge you to improve the rather hand-waving statement

vi has become completely unusable

Without specifics, this bug report leaves a lot of room for improvement. Please use that room and improve the bug report to the point that @nalla or I have a chance to help you resolve your problem.

@sprintr
Copy link
Author

sprintr commented Jun 24, 2015

Did a clean install and it has fixed the problem. Could not repro this after that.

@sprintr sprintr closed this as completed Jun 24, 2015
garimasi514 pushed a commit to garimasi514/git that referenced this issue Jan 6, 2020
This replaces git-for-windows#223. There was a strangely-subtle issue about reading
the trailing hash from the downloaded packs that caused issues when
reading from the origin remote.

Add `gvfs-helper prefetch` command line option
and `objects.prefetch` mode in `gvfs-helper server`.

Sorry, but this contains a major refactor of the packfile and loose file handling
to let me share it with the prefetch code.  As a side benefit, I collapsed the
tempfile creation before the request goes out and merged the install_ code
after the result is returned.

I also changed packfile code to use the packfile-checksum rather than a
timestamp so that we look more like normal Git.

More details are in the commit message.
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Apr 11, 2020
This replaces git-for-windows#223. There was a strangely-subtle issue about reading
the trailing hash from the downloaded packs that caused issues when
reading from the origin remote.

Add `gvfs-helper prefetch` command line option
and `objects.prefetch` mode in `gvfs-helper server`.

Sorry, but this contains a major refactor of the packfile and loose file handling
to let me share it with the prefetch code.  As a side benefit, I collapsed the
tempfile creation before the request goes out and merged the install_ code
after the result is returned.

I also changed packfile code to use the packfile-checksum rather than a
timestamp so that we look more like normal Git.

More details are in the commit message.
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Apr 13, 2020
This replaces git-for-windows#223. There was a strangely-subtle issue about reading
the trailing hash from the downloaded packs that caused issues when
reading from the origin remote.

Add `gvfs-helper prefetch` command line option
and `objects.prefetch` mode in `gvfs-helper server`.

Sorry, but this contains a major refactor of the packfile and loose file handling
to let me share it with the prefetch code.  As a side benefit, I collapsed the
tempfile creation before the request goes out and merged the install_ code
after the result is returned.

I also changed packfile code to use the packfile-checksum rather than a
timestamp so that we look more like normal Git.

More details are in the commit message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants