Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch not deployed #221

Closed
orgads opened this issue Jun 23, 2015 · 5 comments
Closed

patch not deployed #221

orgads opened this issue Jun 23, 2015 · 5 comments

Comments

@orgads
Copy link

orgads commented Jun 23, 2015

patch executable is missing in the release candidate.
@dscho
Copy link
Member

dscho commented Jun 23, 2015

patch.exe is not required by any of Git's components.

@dscho dscho closed this as completed Jun 23, 2015
@orgads
Copy link
Author

orgads commented Jun 23, 2015

That may be right, but it occurred to me a few times that git apply/am failed, and I needed to apply a patch manually. It is useful, why not include it?

@dscho
Copy link
Member

dscho commented Jul 11, 2015

To clarify: Git for Windows' installer really only wants to ship the components necessary to run Git. If you are more of a power user, you are expected to be able to install and use MSys2 (or the Git SDK) which comes with a variety of optional packages.

@orgads
Copy link
Author

orgads commented Aug 30, 2015

Please reconsider:

  • Patch is used by Qt Creator for reverting changes. Removing it from Git distribution required supporting Git as a patch tool, which is implicit.
  • The size of patch is really small: Total Installed Size: 0.15 MiB
  • It is shipped with msysGit 1.x, so excluding it now possibly breaks other user scripts/habits.

@dscho
Copy link
Member

dscho commented Aug 30, 2015

@orgads if you open one of your outstanding Pull Requests, I will merge it.

@orgads orgads mentioned this issue Aug 31, 2015
Merged
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Nov 13, 2019
@derrickstolee
Merge pull request git-for-windows#221: gvfs-helper: handle pack-file…
a5cf005 
… after single POST request

If our POST request includes a commit ID, then the the remote will
send a pack-file containing the commit and all trees reachable from
its root tree. With the current implementation, this causes a
failure since we call install_loose() when asking for one object.

Modify the condition to check for install_pack() when the response
type changes.
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Apr 11, 2020
@derrickstolee
Merge pull request git-for-windows#221: gvfs-helper: handle pack-file…
02ff6cb 
… after single POST request

If our POST request includes a commit ID, then the the remote will
send a pack-file containing the commit and all trees reachable from
its root tree. With the current implementation, this causes a
failure since we call install_loose() when asking for one object.

Modify the condition to check for install_pack() when the response
type changes.
jeffhostetler pushed a commit to jeffhostetler/git that referenced this issue Apr 13, 2020
@derrickstolee
Merge pull request git-for-windows#221: gvfs-helper: handle pack-file…
d12d17a 
… after single POST request

If our POST request includes a commit ID, then the the remote will
send a pack-file containing the commit and all trees reachable from
its root tree. With the current implementation, this causes a
failure since we call install_loose() when asking for one object.

Modify the condition to check for install_pack() when the response
type changes.
jeffhostetler added a commit to jeffhostetler/git that referenced this issue Jun 3, 2020
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
b098b57 
Includes commits from these pull requests:

	git-for-windows#191
	git-for-windows#205
	git-for-windows#206
	git-for-windows#207
	git-for-windows#208
	git-for-windows#215
	git-for-windows#220
	git-for-windows#221

Signed-off-by: Derrick Stolee <[email protected]>
jeffhostetler added a commit to jeffhostetler/git that referenced this issue May 14, 2021
@jeffhostetler
Merge first wave of gvfs-helper feature
8f70ba6 
Includes commits from these pull requests:

	git-for-windows#191
	git-for-windows#205
	git-for-windows#206
	git-for-windows#207
	git-for-windows#208
	git-for-windows#215
	git-for-windows#220
	git-for-windows#221

Signed-off-by: Derrick Stolee <[email protected]>
jeffhostetler added a commit to jeffhostetler/git that referenced this issue Jun 21, 2021
@jeffhostetler @dscho
Merge first wave of gvfs-helper feature
d94022b 
Includes commits from these pull requests:

	git-for-windows#191
	git-for-windows#205
	git-for-windows#206
	git-for-windows#207
	git-for-windows#208
	git-for-windows#215
	git-for-windows#220
	git-for-windows#221

Signed-off-by: Derrick Stolee <[email protected]>
jeffhostetler added a commit to jeffhostetler/git that referenced this issue Aug 18, 2021
@jeffhostetler @derrickstolee
Merge first wave of gvfs-helper feature
b013f94 
Includes commits from these pull requests:

	git-for-windows#191
	git-for-windows#205
	git-for-windows#206
	git-for-windows#207
	git-for-windows#208
	git-for-windows#215
	git-for-windows#220
	git-for-windows#221

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit to mjcheetham/git that referenced this issue Jun 16, 2022
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
579c64d 
Includes commits from these pull requests:

	git-for-windows#191
	git-for-windows#205
	git-for-windows#206
	git-for-windows#207
	git-for-windows#208
	git-for-windows#215
	git-for-windows#220
	git-for-windows#221

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit to mjcheetham/git that referenced this issue Jul 23, 2024
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
c2db5a3 
Includes commits from these pull requests:

	git-for-windows#191
	git-for-windows#205
	git-for-windows#206
	git-for-windows#207
	git-for-windows#208
	git-for-windows#215
	git-for-windows#220
	git-for-windows#221

Signed-off-by: Derrick Stolee <[email protected]>
mjcheetham pushed a commit to mjcheetham/git that referenced this issue Jan 20, 2025
@jeffhostetler @mjcheetham
Merge first wave of gvfs-helper feature
b546376 
Includes commits from these pull requests:

	git-for-windows#191
	git-for-windows#205
	git-for-windows#206
	git-for-windows#207
	git-for-windows#208
	git-for-windows#215
	git-for-windows#220
	git-for-windows#221

Signed-off-by: Derrick Stolee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dscho @orgads