Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Git kills command prompt (Windows) when using "git submodule update --init --recursive". Previous version does not #1312

Closed
kkennett opened this issue Oct 2, 2017 · 10 comments
Assignees
Milestone

Comments

@kkennett
Copy link

kkennett commented Oct 2, 2017

  • [X ] I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
$ git --version --build-options

git version 2.14.2.windows.1
built from commit: 788debdfb6b794425a3b949dd1a0eb2425a72e96
sizeof-long: 4
machine: x86_64

  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver

Microsoft Windows [Version 10.0.15063]

  • What options did you set as part of the installation? Or did you choose the
    defaults?
# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Path Option: Cmd
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: ConHost
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Disabled

  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

No. Install 2.14.1.windows.1 and things work fine. Install 2.14.2.windows.1 and problem presents.

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Cmd


git clone <url> <local name>
git submodule update --init --recursive

  • What did you expect to occur after running these commands?

submodules to update

  • What actually happened instead?

submodules start to update, but then command window just disappears (crashed).

  • If the problem was occurring with a specific repository, can you provide the
    URL to that repository to help us with testing?

No. Internal private repository.

@dscho
Copy link
Member

dscho commented Oct 2, 2017

No. Internal private repository.

Maybe you can initialize a minimal public repository to make this much easier to reproduce, and to verify in the process that this is not specific to your repository.

@dscho dscho added the unclear label Oct 2, 2017
@patrick984
Copy link

patrick984 commented Oct 3, 2017

I have observed the same issue when using the git-subrepo module. Any of the git subrepo ... commands cause the terminal window to disappear immediately (however the bash.exe process stays alive forever). Reverting to 2.14.1.windows.1 fixes the problem.

To reproduce first install git subrepo (https://github.com/ingydotnet/git-subrepo) then using git bash:

mkdir test-repo
cd test-repo
git init
mkdir test-subrepo
touch test-subrepo/a.txt
git add test-subrepo/a.txt
git commit -m initial
git subrepo init test-subrepo

The command window will then disappear if using 2.14.2.

@csmager
Copy link

csmager commented Oct 3, 2017

This sounds like the same thing I get with git lfs when using 2.14.2. I logged at git-lfs: git-lfs/git-lfs#263.

When the git lfs hooks are installed and I'm in a repo that uses LFS, both PowerShell and CMD will quit after e.g. git push. Rolling back to 2.14.1 resolves the problem.

@kkennett
Copy link
Author

kkennett commented Oct 4, 2017

i am not able to do much right now as i am away from my system. patrick984 has a repo - can you try that? Can we roll back to the previous version until this problem is resolved?

@dscho
Copy link
Member

dscho commented Oct 4, 2017

I logged at git-lfs: git-lfs/git-lfs#263.

@csmager you probably meant git-lfs/git-lfs#2631 instead.

@dscho
Copy link
Member

dscho commented Oct 4, 2017

After 3h of bug hunting, I found not only the problem, but also that it was already fixed in Cygwin: cygwin/cygwin@21a39b2 (I simply did not see it before today and consequently failed to adjust Git for Windows accordingly).

@dscho
Copy link
Member

dscho commented Oct 5, 2017

I think this is fixed by git-for-windows/MSYS2-packages@e9d0a2b.

@dscho
Copy link
Member

dscho commented Oct 5, 2017

If all goes well, a new snapshot will appear at https://wingit.blob.core.windows.net/files/index.html within the hour. When it does, please test?

@OtherShadeOfBlue
Copy link

@dscho That snapshot fixes it for me.
I have a several scripts that broke for the same reason and work again using your snapshot.

@dscho
Copy link
Member

dscho commented Oct 5, 2017

@OtherShadeOfBlue thanks for the feedback!

@dscho dscho closed this as completed Oct 5, 2017
dscho added a commit to git-for-windows/build-extra that referenced this issue Oct 5, 2017
A [bug](git-for-windows/git#1312)
which caused the console window to be closed
when executing certain Bash scripts [was
fixed](git-for-windows/MSYS2-packages@e9d0a2b).

Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants