Fix the updpkgsums GitHub workflow
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom `init-g4w-for-pacman` Action initializes a subset of Git for Windows' SDK via a specific sparse checkout. To make things a bit more efficient, this sparse checkout is cached using the `actions/cache` Action. To that end, a cache key is defined. It is actually defined twice, once in the `restore` step and once in the `save` step. This leaves room to forget updating the cache key in one of the two places when it is changed. Let's just define it in a single location instead. Signed-off-by: Johannes Schindelin <[email protected]>
When the `updpkgsums` workflow runs, it initializes a subset of Git for Windows SDK's repository via a sparse checkout. This subset is defined in the custom `init-g4w-sdk-for-pacman` Action, and it works well for `pacman`/`updpkgsums` invocations. For `makepkg`, however, we need to include the Pacman configuration, and `gpg.exe`,otherwise the workflow will fail with an error message like this: ==> Checking runtime dependencies... error: config file /etc/pacman.conf could not be read: No such file or directory This happened in this failed workflow run: https://github.com/git-for-windows/git-for-windows-automation/actions/runs/9415088089/job/25935346092#step:9:87 Fix this by including the Pacman configuration and `gpg.exe in the sparse checkout. Signed-off-by: Johannes Schindelin <[email protected]>
|
Here is a successful run that verifies that no messages like these are shown: These would be shown unless a working Took a while to figure out how best to include the missing bits, but finally I managed that trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never had verified that the
/updpkgsumsslash command works, up until last week, when I tried to run it in git-for-windows/build-extra#558. Turns out that it needed a couple of fixes. git-for-windows/gfw-helper-github-app#83 was needed on the GitHub App side, and this here PR is needed to actually let the operation succeed.