Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NotPad.sh #76

Closed
wants to merge 1 commit into from
Closed

Create NotPad.sh #76

wants to merge 1 commit into from

Conversation

Dirk1966
Copy link

Wrapper for using notepad.exe as commit editor

This enables using Windows' notepad.exe to work as commit editor inside of "git for Windows"

Fixes 381 from git for Windows.

Signed-off-by: Dirk1966 [email protected]

@kusma
Copy link

kusma commented Sep 14, 2015

Nice 👍

@dscho
Copy link
Member

dscho commented Sep 14, 2015

See git-for-windows@ master...dscho:notepad for my take on it.

@dscho
Copy link
Member

dscho commented Sep 14, 2015

See git-for-windows@ master...dscho:notepad for my take on it.

@Dirk1966 did you have a chance to look at it yet?

@Dirk1966
Copy link
Author

Hi Dscho,
I looked at your script, it is very short and should do all what you want.
👍
I think "git for Windows 1" does not have dos2unix and unix2dos, at least I looked at somebody which installation did not have this.
Even if I can understand you want avoid using perl, a
perl -p -i -e 's/\n$/\r\n/g'
and
perl -p -i -e 's/\r\n$/\n/g'
should be able to replace dos2unix and unix2dos and are usable from old installations too. I got a message from dos2unix that it created an intermediate file.

@dscho
Copy link
Member

dscho commented Sep 14, 2015

Thanks for the confirmation! I am pretty certain that dos2unix does not, in fact, leave a temporary file, but if it does, I will use the perl invocation you suggested.

@dscho dscho closed this Sep 14, 2015
@Dirk1966
Copy link
Author

dos2unix does not leave a temporary file, but it uses one.

On Mon, Sep 14, 2015, 19:24 Johannes Schindelin [email protected]
wrote:

Thanks for the confirmation! I am pretty certain that dos2unix does not,
in fact, leave a temporary file, but if it does, I will use the perl
invocation you suggested.


Reply to this email directly or view it on GitHub
#76 (comment)
.

@dscho
Copy link
Member

dscho commented Sep 15, 2015

dos2unix does not leave a temporary file, but it uses one.

Do you know that for a fact? Or is this something you heard about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants