Only use 'antiword' in 'astextplain' if 'file' identified a Word document #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vampire
changed the title
…ment Without this change you always get output that a given file is not a Word document, for example during pickaxeing. Signed-off-by: Björn Kautler <[email protected]>
dscho
approved these changes
Aug 15, 2022
| @@ -12,7 +12,14 @@ case "$1" in | |||
| odt2txt "$1" || cat "$1" | |||
| ;; | |||
| *.doc | *.DOC | *.dot | *.DOT) | |||
| out=$(antiword -m UTF-8 "$1") && sed "s/\^M$//" <<<$out || cat "$1" | |||
| case "$(file --brief --mime-type "$1")" in | |||
There was a problem hiding this comment.
My first reaction was to be concerned about the time spent on spawning file, but file has hard enough of a time to identify all the Word Document flavors that the alternative (namely, to hand-roll a script to identify Word Documents) seems prohibitive.
My next reaction was to be concerned about MinGit, but then I looked and found out that MinGit does not ship with astextplain (nor with file, for that matter).
dscho
added a commit
that referenced
this pull request
Aug 15, 2022
Git for Windows [now correctly handles `.doc` files that are not Word Documents](#432). Signed-off-by: Johannes Schindelin <[email protected]>
|
@Vampire thank you for your contribution! |
This comment was marked as spam.
This comment was marked as spam.
svraka
added a commit
to svraka/dotfiles
that referenced
this pull request
Mar 5, 2024
See [1] and [2]. [1]: git-for-windows/build-extra#403 [2]: git-for-windows/build-extra#432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change you always get output that a given file is not a Word document, for example during pickaxeing.