Fix auto-updater when an -rc0 version is installed #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have logic that prevents the updater from suggesting to downgrade from "release candidates" to the previous official version. However, the logic only caught -rc1, -rc2, etc, but not -rc0. Let's also catch -rc0. Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
approved these changes
May 19, 2021
dscho
added a commit
that referenced
this pull request
May 19, 2021
The auto-updater [no longer suggests to downgrade from -rc0 versions](#347). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently installed v2.32.0-rc0 and the auto-updater suggested to "upgrade" to v2.31.1. This fixes that.