Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: add 64-bit support for ARM64 #333

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Mar 21, 2021

Builds further on #330

The Git for Windows ARM64 installation ideally should be installed in the 64-bit Program Files folder. Inno Setup 6.0 added support for 64-bit on Windows ARM64. This commit leverages this support.

The installation directory is correctly set to C:\Program Files\Git:

image

The Git Credential Manager radio buttons are enabled correctly in the 64-bit ARM64 installer:

image

installer/install.iss Outdated Show resolved Hide resolved
The Git for Windows ARM64 installation ideally should be installed in
the 64-bit Program Files folder. Inno Setup 6.0 added support for 64-bit
on Windows ARM64. This commit leverages this support.

Signed-off-by: Dennis Ameling <[email protected]>
@dennisameling dennisameling force-pushed the installer-arm64-64-bit branch from f7a3670 to 13466bf Compare April 19, 2021 19:54
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I was a bit concerned about defining INSTALLER_FILENAME_SUFFIX when we don't want any suffix, but it does seem like the cleanest solution (because unlike a proper C preprocessor, #if defined(INSTALLER_FILENAME_SUFFIX) && INSTALLER_FILENAME_SUFFIX!='' would still result in the error message Undeclared identifier: INSTALLER_FILENAME_SUFFIX.).

@dscho dscho merged commit 938c196 into git-for-windows:main Apr 20, 2021
@dscho
Copy link
Member

dscho commented Apr 20, 2021

@dennisameling thank you so much!

@dennisameling dennisameling deleted the installer-arm64-64-bit branch April 21, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants