Fix recall of experimental pseudo console support setting #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pseudo Console support experimental option was not being recalled correctly on subsequent installs. If the option was unset it would default to unchecked (correct), but if the option was set to 'disabled' then it would become default checked! Signed-off-by: Matthew John Cheetham <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
|
Thank you @mjcheetham! |
dscho
added a commit
that referenced
this pull request
Jun 13, 2020
When reinstalling (or upgrading) Git for Windows, [the "Pseudo Console Support" choice is now remembered correctly](#295). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pseudo Console support experimental option was not being recalled
correctly on subsequent installs. If the option was unset it would
default to unchecked (correct), but if the option was set to 'disabled'
then it would become default checked!
Signed-off-by: Matthew John Cheetham [email protected]