Offer the SDK by simply cloning it (closes #1357) #171
Conversation
|
Alright, I'll try to come up with a new series. |
|
Thanks! Please just force-push your branch once ready, this will update the PR as well. |
|
@bbolli do you need anything from my side, or are you simply pressed for time (as we all are)? |
|
@dscho Actually I was on vacation, but I'll put in a few hours this weekend. Stay tuned... |
Thanks! |
@bbolli what do you think of this |
|
I'm in the process of implementing it. What other features should it have besides those in your sample? |
Great!
I think we will find more and more things we will want to do, on the go. I could imagine for example that it would be nice if there was an easy way to build a custom installer pulling in a git-extra from PR #171 and Git from PR git-for-windows/git#1492 ;-) But I think that it would be good to just have something for starters, and not block this here PR for possible crazy feature requests ;-) |
git-extra/git-sdk.sh
Outdated
| sdk () { | ||
| case "$1" in | ||
| help|--help|-h) | ||
| echo "The '$0' shell function helps you to get up and running |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
git-extra/git-sdk.sh
Outdated
| @@ -20,3 +20,52 @@ case "$rootdir" in | |||
| fi | |||
| ;; | |||
| esac | |||
|
|
|||
|
|
|||
| sdk () { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Let our developers-to-be get started in a less intimidating way. See the built-in help (`sdk help`) for its subcommands. This addresses git-for-windows/git#1357. Signed-off-by: Beat Bolli <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
git-extra/git-sdk.sh
Outdated
| mkdir -p "$dest" && | ||
| git init "$dest" && | ||
| git -C "$dest" remote add origin https://github.com/git-for-windows/$2 | ||
| fi && |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@bbolli I added a few commits and force-pushed to your branch; I hope you do not mind... Could you have a look and tell me what you think? |
git-extra/git-sdk.sh
Outdated
| ;; | ||
| *) | ||
| sdk die "Unhandled repository: $2" >&2 | ||
| ;; | ||
| esac | ||
| ;; | ||
| init) | ||
| init_lazy "$2" && |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
The git/, build-extra/, MINGW-packages/ and MSYS2-packages/ worktrees are pretty important in the Git for Windows SDKs. Let's initialize them by default so that they are there (but do not fetch them just yet, just set up core.autoCRLF=false and the `origin` remote). This is in line with the way the SDK installer worked so far: the idea of this commit & friends is to replace the SDK installer by a simple git clone https://github.com/git-for-windows/git-sdk-64 && git-sdk-64/git-bash.exe For historical reasons, we do *not* initalize those worktrees in the SDK installer if the environment variable `JENKINS_URL` is set. Signed-off-by: Johannes Schindelin <[email protected]>
This is another step toward replacing the SDK installer by a simple clone of https://github.com/git-for-windows/git-sdk-64. Signed-off-by: Johannes Schindelin <[email protected]>
It makes sense to tell the user a few things or two... Signed-off-by: Johannes Schindelin <[email protected]>
One of the most important things users will want to do is to build a custom installer. Let's offer an easy way to do that, too. Signed-off-by: Johannes Schindelin <[email protected]>
When the user did not specify anything to build, or something we do not know about, let's just print a list of supported build targets and error out. Signed-off-by: Johannes Schindelin <[email protected]>
Many feature requests involve improvements to the installer. Let's make that easy by letting the user build it with sdk build installer Signed-off-by: Johannes Schindelin <[email protected]>
|
@bbolli I would like to merge this as soon as possible, no idea what your availability is these days? I guess I'll just wait a couple minutes and then merge, build a new |
|
@bbolli I hope you don't mind that I merge this already ;-) |
|
To clarify: I think it was most important to get this into the SDK, and we can easily develop it further from here. Thank you @bbolli for getting the ball rolling! |
dscho
changed the title
|
Sure, no problem! |
No description provided.