Skip to content

Commit

Permalink
installer: check again for blocking processes before complaining
Browse files Browse the repository at this point in the history
Just before installing, we check for processes that still use files we
want to overwrite, and show the Processes page if such processes were
found.

When that happens, users typically close the corresponding windows and
then come back to the installer window.

While it would be nice to update the list when the focus is regained,
InnoSetup unfortunately lacks support for that right now.

So what happens is that the user clicks `Install` and gets a bogus
warning about the processes that need to be done before we can proceed,
forcing the user to click the `Refresh` button first.

What we *can* do, however, is to simply update the processes list right
before we would complain about the blocking processes, as if the user
had clicked the `Refresh` button first. So let's do that.

Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
dscho committed Sep 12, 2017
1 parent 8fc7e52 commit d984925
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions installer/install.iss
Original file line number Diff line number Diff line change
Expand Up @@ -1549,6 +1549,7 @@ begin
SuppressibleMsgBox('{#PLINK_PATH_ERROR_MSG}',mbError,MB_OK,IDOK);
end;
end else if (ProcessesPage<>NIL) and (CurPageID=ProcessesPage.ID) then begin
RefreshProcessList(NIL);
// It would have been nicer to just disable the "Next" button, but the
// WizardForm exports the button just read-only.
for i:=0 to GetArrayLength(Processes)-1 do begin
Expand Down

0 comments on commit d984925

Please sign in to comment.