Skip to content

Commit

Permalink
Add column.exe to the installed files
Browse files Browse the repository at this point in the history 
column.exe is included for the benefit of https://github.com/tj/git-extras
which uses column.exe in git line-summary, git summary and git ignore-io.

It's a 25kb file with no additional dependencies (msys-intl-8.dll,
msys-iconv-2.dll and msys-2.0.dll are all included already). From the
util-linux package...

Closes: git-for-windows/git#586

Signed-off-by: Jan Schulz <[email protected]>
  • Loading branch information
@jankatins
jankatins committed Jan 6, 2016
1 parent 3b9db1b commit 2fc568a
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions make-file-list.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,9 @@ mingw$BITNESS/etc/gitattributes
mingw$BITNESS/bin/pdftotext.exe
mingw$BITNESS/bin/libstdc++-6.dll
EOF

# extras
# https://github.com/git-for-windows/git/issues/586
# for https://github.com/tj/git-extras -> used in git line-summary, git summary and git ignore-io
# from util-linux, 25kb, deps on msys-intl-8.dll, msys-iconv-2.dll, msys-2.0.dll (all included already)
echo "usr/bin/column.exe"

4 comments on commit 2fc568a

@sergeevabc
Copy link

@sergeevabc sergeevabc commented on 2fc568a Oct 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanSchulz, could you be so kind to compile column.exe which would work standalone without dependencies? I was lucky to find sed, sort and a few other gems, but this one is yet to be found.

@dscho
Copy link
Member

@dscho dscho commented on 2fc568a Nov 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you be so kind to compile column.exe which would work standalone without dependencies?

@sergeevabc please note that you are asking for quite a lot: column.exe is compiled as part of the util-linux package. It implicitly requires the POSIX emulation provided by the MSYS2 runtime, it also requires libintl and libiconv. It would take a substantial effort to rewrite the code so that it does not need those dependencies. It would be easier to rewrite column.exe's source code from scratch. Which is another big task, so it is probably not a wise idea to burden others with that feature request.

@sergeevabc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dscho, being not a developer, but a mere Windows user in pursuit of keeping records in order, I’m not that aware of the complexity of implementation. Size of the original column and the existence of other standalone ports made me think there was no harm in asking. In case another wandering soul stumbles upon this conversation, let me reassure there is a way to align data, although semi-automatic, by means of Gawk.

$ gawk '{printf("%-30s %8s %8s\n", "Name", "Address", "Size")}'
Name                            Address     Size

@dscho
Copy link
Member

@dscho dscho commented on 2fc568a Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergeevabc if you are not a developer, I wonder why you are commenting directly on a commit, where there is little chance of anybody seeing your comment except the patch author and the maintainer.

Also, your comment about gawk seems to forget about the main intention of using column.exe: to figure out the column widths automatically.

In any case, I laid out why your request is leaning a bit heavily on potential helpers, so I still think that the most reasonable course of action would be to learn enough code to scratch your own itch.

Please sign in to comment.