-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: add installer validation #813
release: add installer validation #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
I had a few suggestions, but would also be fine with the current iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Some of the comments from the others would help debugging problems and speed things up.
Add basic installer validation to release pipeline for Windows, macOS (x64 only), and Linux (Debian package only). Validation runs the installers/any necessary setup and checks that the installed version matches the expected version.
a2209c9
to
d94c254
Compare
I believe we are all good on this! Here is the latest successful test run: https://github.com/ldennington/git-credential-manager/actions/runs/2852519783. |
- name: Validate | ||
shell: bash | ||
run: | | ||
"${{ matrix.component.command }}" --version | sed 's/+.*//' >actual | ||
echo $GitBuildVersionSimple >expect | ||
cmp expect actual || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Changes: - Check for broken links in documentation (#700) - Support macOS `arm64` installs via Homebrew (#798) - Validate installers before publishing (#813) - Auto-generate maintainer away notification issues (#842) - Install dotnet via Jammy feeds on Ubuntu 22.04 and greater (#839) - Access Azure storage account using service principle credentials (#851) - Update documentation to use reference-style links (#680) - Unify documentation line length (#862) - Add generic username/password UI (#871) - Bitbucket DC OAuth support (#607) - Distribute GCM as a dotnet tool (#886) - Drop `-core` suffix from entry executable #551 - Speed up build graph (#924)
Add basic installer validation to release pipeline for Windows,
macOS (x64 only), and Linux (Debian package only). Validation runs the
installers/any necessary setup and
git-credential-manager-core --version
.Test run validating these changes can be found here.