Set credential.provider after successful auto detection probe
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
requested review from
derrickstolee,
ldennington,
vdye,
jeffhostetler and
dscho
mjcheetham
force-pushed
the
discovery-setconfig
branch
from
b6f6aa5 to
e024b9d
Compare
After we've detected the host provider from an auto-detection network probe, set the `credential.provider` setting so we can avoid the expensive operation in the future. If we fail to set this then warn the user and ask them to set the configuration manually.
mjcheetham
force-pushed
the
discovery-setconfig
branch
from
e024b9d to
564045e
Compare
derrickstolee
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we've detected the host provider from an auto-detection network probe, set the
credential.providersetting so we can avoid the expensive operation in the future. This greatly improves the performance of subsequent credential requests.If we fail to set this then warn the user and ask them to set the configuration manually.
Fixes #507