Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for generating code coverage reports #499

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

mminns
Copy link
Contributor

@mminns mminns commented Oct 19, 2021

Problem

I'd like to refactor parts of the Bitbucket code, but I'm uncomfortable about the level of security provided by the automated testing to avoid regressions.

I'd like to expand the testing, so I'd like to know what is currently tested or not.

Solution

This adds a first pass at adding basic code coverage metrics and reporting.
They have to be run manually, they are not currently wired up to CI etc, I'd suggest doing that in a follow up.

@mminns
Copy link
Contributor Author

mminns commented Oct 19, 2021

Uploading Screenshot 2021-10-19 at 15.25.03.png…

@mminns mminns force-pushed the issue/498-add-code-coverage branch from 902d307 to 15fdf1b Compare November 22, 2021 09:49
@mminns mminns changed the title Basic support for generating code coverage reports Add basic support for generating code coverage reports Nov 22, 2021
@mminns mminns marked this pull request as ready for review November 22, 2021 10:00
@dscho
Copy link
Collaborator

dscho commented Nov 22, 2021

Could this also be integrated into the CI builds?

@mminns
Copy link
Contributor Author

mminns commented Nov 22, 2021

Yes, I don't see why not.

I'm not as familiar with the CI setup as I probably should be to understand where it would fit, where you would see the results etc.

I had assumed I'd do that as a follow up if the general idea was agreed.

@mjcheetham mjcheetham self-assigned this Nov 25, 2021
Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mminns! Thanks for contributing this 😁

@mjcheetham mjcheetham merged commit e65cf96 into git-ecosystem:main Nov 25, 2021
@mminns
Copy link
Contributor Author

mminns commented Nov 25, 2021

👍 Thanks

@ldennington ldennington mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants