Speed up host provider auto-detection and make more robust #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up the auto-detection mechanism in the
HostProviderRegistry
by setting a short(er) timeout on the probing network call (2 seconds). The default value from the framework is otherwise 100 seconds(!).We introduce a setting for the user to be able to configure this timeout value with the granularity of 1 millisecond.
Another problem that occurred with this network call was crashes due to TLS configuration issues. The network call was not wrapped in a
try-catch
block which meant that the entire process would crash if there was a problem. This isn't ideal for what is supposed to be a "best effort" feature. Here we wrap the HEAD call in atry-catch
and displayan appropriate warning message to the user.
For completeness, add documentation that explains the auto-detection feature, how to configure the timeout, and how to disable this network call.
Fixes #384