Only enumerate local Azure Repos user bindings when inside a repository #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only attempt to enumerate Azure Repos user bindings in the local Git configuration, when inside a Git repository.
If application tracing is enabled, also print any exception stack traces to standard error.
derrickstolee
approved these changes
Aug 17, 2021
Comment on lines
+133
to
+137
| // If tracing is enabled then also print the stack trace to stderr | ||
| bool printStack = Context.Settings.GetTracingEnabled(out _); | ||
| if (printStack) | ||
| Context.Streams.Error.WriteLine(ex.StackTrace); | ||
|
|
There was a problem hiding this comment.
hyper-nit: the variable printStack is not necessary as it is not re-used.
There was a problem hiding this comment.
Yeah, I'm explicitly putting this intermediate variable there to make it very clear the reason for using GetTracingEnabled(..) in "normal" exception logging code. I guess the comment above also explains this explicit decision.
I'd imagine (hope) the CLR JIT would be smart enough to elide the local variable in this case, but also if we're at the point of having to print an exception and die, perf is not a concern(!)
vdye
approved these changes
Aug 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attempt to enumerate Azure Repos user bindings in the local Git configuration, when inside a Git repository.
Also print any exception stack traces to standard error if application tracing is enabled to aid in debugging such issues "in the wild".
Fixes #416