Add support for sending X5C when using a service principal with certificate for authentication #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2024 14:04
mjcheetham
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Thank you for this addition! Just a few things please:
- address the comment about parsing the config values
- drop the VERSION file change
- please can you also add docs for the
GCM_AZREPOS_SP_CERT_SEND_X5Candcredential.azreposServicePrincipalCertificateSendX5Csettings to the corresponding markdown docs in/docs!
😄
added 3 commits
July 18, 2024 16:51
…n parsing a boolean config option
…w x5c MSAL claim option
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mjcheetham
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a service principal with certificate authentication, every time the certificate is renewed, the new certificate needs to be uploaded to the service principal's AAD app registration in order for authentication to continue to work.
However, a technology called "X5C" has made this unnecessary by allowing any certificate, with a specific subject, issued by a known, trusted, predetermined CA, to be used.
For this to work, the AAD app registration's manifest needs to be updated to reflect the subject name, and during authentication, the request for "X5C" authentication needs to be sent along with the certificate's signature.
This change enables that to take place.