Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-from-source: update libssl for alpine #1574

Closed
wants to merge 1 commit into from

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Apr 8, 2024

The validate-install-from-source workflow is currently failing [1]. According
to [2] and [3], the solution is to upgrade the libssl version from 1.1 to 3, as
version 1.1 is out of support. Since this version is only supported on Alpine
3.15 and later, we detect the version of Alpine the user is running on and set
this dependency version accordingly.

1: https://github.com/git-ecosystem/git-credential-manager/actions/runs/8604126129
2: https://stackoverflow.com/questions/77640298/dockerfile-unable-to-select-packages-linux-alpine
3: https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine

@mjcheetham
Copy link
Collaborator

mjcheetham commented Apr 15, 2024

This is the same PR as what @dscho did in #1535

The same issue occurs however in that we need to still use libssl1.1 for older versions of Alpine, so we need to update the script to switch on the Alpine version.

@ldennington
Copy link
Contributor Author

The same issue occurs however in that we need to still use libssl1.1 for older versions of Alpine, so we need to update the script to switch on the Alpine version.

Not quite sure if I picked up what you're putting down, but I added a check to make sure the user is running on 3.15 or greater. Will that suffice?

mjcheetham added a commit that referenced this pull request Apr 15, 2024
Update the install from source script on Linux to install the .NET 8
SDK.

Verified this fix in manual run of
https://github.com/git-ecosystem/git-credential-manager/actions/runs/8697380253

Note the Alpine issue is to be fixed in a separate PR:
#1574
Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to propose this PR address this issue instead:
#1582

It copes with both 3.14 and 3.15+ Alpine requirements.

The `validate-install-from-source` workflow is currently failing [1]. According
to [2] and [3], the solution is to upgrade the libssl version from 1.1 to 3, as
version 1.1 is out of support. Since this version is only supported on Alpine
3.15 and later, we detect the version of Alpine the user is running on and set
this dependency version accordingly.

1: https://github.com/git-ecosystem/git-credential-manager/actions/runs/8604126129
2: https://stackoverflow.com/questions/77640298/dockerfile-unable-to-select-packages-linux-alpine
3: https://learn.microsoft.com/en-us/dotnet/core/install/linux-alpine
@ldennington
Copy link
Contributor Author

ldennington commented Apr 16, 2024

Not quite sure if I picked up what you're putting down, but I added a check to make sure the user is running on 3.15 or greater. Will that suffice?

Actually, thinking about this a little more, it seemed like the best idea would be to set the version of libssl based on the version of Alpine the user is running. I've made updates accordingly and tested both scenarios (>3.14 and 3.14 and below) in my fork.

@ldennington
Copy link
Contributor Author

I'd like to propose this PR address this issue instead:

#1582

It copes with both 3.14 and 3.15+ Alpine requirements.

Sorry! I didn't see this before submitting my updates. I'll take a look at your PR.

@ldennington
Copy link
Contributor Author

Closed in favor of #1582

mjcheetham added a commit that referenced this pull request Apr 16, 2024
The version of libssl available in the Alpine package feeds changed with
version 3.15. The latest libssl package is 1.1 in 3.14.x and earlier,
but newer versions only have libssl3.

Add a check for the Alpine version in the install from source script and
switch between installing libssl3 and libssl1.1 depending on the distro
version.

Also add another entry to the test matrix of distributions to include a
3.14.x Alpine version.

This replaces the two other PRs that aimed to address this issue:
- #1535
- #1574

Tested the updated workflow here:
https://github.com/git-ecosystem/git-credential-manager/actions/runs/8698286553/job/23855027830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants