Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update homebrew deployment #1386

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Aug 21, 2023

Update release-homebrew workflow to use the brew bump-cask-pr command. This aligns with the Homebrew project's official recommendations for creating PRs in the Homebrew/homebrew-cask tap and removes GCM's dependency on the mjcheetham/update-homebrew task.

This workflow was tested with this PR to Homebrew/homebrew-cask.

Update `release-homebrew` workflow to use the `brew bump-cask-pr` command [1].
This aligns with the Homebrew project's official recommendations for creating
PRs in the `Homebrew/homebrew-cask` tap and removes GCM's dependency on the
`mjcheetham/update-homebrew` task [2].

1: https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#submit-a-new-version-of-an-existing-cask
2: https://github.com/mjcheetham/update-homebrew
@ldennington ldennington self-assigned this Aug 21, 2023
environment: release
env:
HOMEBREW_GITHUB_API_TOKEN: ${{ secrets.HOMEBREW_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What permissions does this token require? Looks like it acts similarly to the old task (but works!) in that it'll create a fork, a branch in the fork, and the PR back to homebrew/cask.

This creates a personal remote repository that you can push to. This is needed because only Hombrew maintainers have push access to the main repositories.

https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#cask-related-pull-request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's correct! Also, if the fork already exists, it just creates a new branch and the PR. Token-wise I made no changes, just used the one I'd already created for testing GCM's release workflows in my fork (which has the same permissions as the one in the main repo).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Just something to bear in mind the next time someone updates this token after expiration that it'll be their identity that the fork is created in.

@ldennington ldennington merged commit e076f58 into git-ecosystem:main Aug 21, 2023
@ldennington ldennington deleted the update-homebrew-release branch August 22, 2023 21:52
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

_Since 2.4.0:_

- Fix macOS ARM64 tarball contents (#1458)

_Since 2.3.x:_

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants