Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential popups don't show any context information #239

Closed
johnendev opened this issue Nov 29, 2020 · 8 comments · Fixed by #347 or #512
Closed

Credential popups don't show any context information #239

johnendev opened this issue Nov 29, 2020 · 8 comments · Fixed by #347 or #512
Assignees
@mjcheetham
Labels
auth:microsoft Specific to Microsoft AAD/MSA authentication blocked Progress on this issue is blocked. enhancement New feature or request external Relating to an external partner, team, or library

Comments

@johnendev
Copy link

When the credential manager pops up asking for credentials there is no context about which repository or program is requesting access.
I have some background tasks which perform git operations now and then, and sometimes windows decides to drop stored creds so I get the cred popups without any context or user interaction and it just seems a lot like phishing.

It should at least show something to identify which repo/program the creds are being requested for before the user takes action.
@mjcheetham
Copy link
Collaborator

Would require support from the MSAL library; requested this change here:

AzureAD/microsoft-authentication-library-for-dotnet#2397

@mjcheetham mjcheetham added auth:microsoft Specific to Microsoft AAD/MSA authentication enhancement New feature or request external Relating to an external partner, team, or library labels Feb 9, 2021
@mjcheetham mjcheetham mentioned this issue May 14, 2021
Merged
@mjcheetham mjcheetham mentioned this issue May 17, 2021
Merged
@mjcheetham
Copy link
Collaborator

Reopening because GCM is not using the WebView2 embedded browser still due to an oversight whereby we are not calling WithDesktopFeatures() on MSAL that is required to opt-in to using WebView2 on .NET Framework.

HOWEVER.. we still cannot add this feature because of some issues with loading the WebView2 runtime:
AzureAD/microsoft-authentication-library-for-dotnet#2633

@mjcheetham mjcheetham reopened this May 17, 2021
@mjcheetham mjcheetham self-assigned this May 17, 2021
@vtbassmatt vtbassmatt added the blocked Progress on this issue is blocked. label Oct 7, 2021
@mjcheetham
Copy link
Collaborator

@bgavrilMS is there any chance of getting the "window title" support added to WebView1 (not WV2) in MSAL?
GCM isn't using WV2 right now due to various problems.

@bgavrilMS
Copy link

Yes, sure.

@bgavrilMS
Copy link

WV2 isn't working that well for us either, so I think we should add it to WV1 as it isn't going away any time soon.

@mjcheetham
Copy link
Collaborator

Yes, sure.

Hopefully it should be a small change in the WV1 code; just setting the Window title from the EmbeddedWebViewOptions.WindowTitle property.

@mjcheetham
Copy link
Collaborator

PR to add the window title to the WebView1 window: AzureAD/microsoft-authentication-library-for-dotnet#2936

@mjcheetham mjcheetham mentioned this issue Oct 12, 2021
Closed
mjcheetham added a commit to mjcheetham/git-credential-manager that referenced this issue Nov 2, 2021
@mjcheetham
msauth: update to MSAL.NET 4.37
45430f9 
Update our MSAL.NET dependency to 4.37 from 4.31. This should come with
the following updates/fixes that we care about:

- Can set embedded web view (legacy) window title to custom message
  (required for git-ecosystem#239)
- Fixes some problems with WAM dialogs appearing behind parent windows
- Moves WAM to no longer being experimental
- Better MSA-PT support when used with WAM
- Numerous performance improvements with authority discovery
- Various WAM bug fixes
mjcheetham added a commit to mjcheetham/git-credential-manager that referenced this issue Nov 2, 2021
@mjcheetham
msauth: update to MSAL.NET 4.37
73cb423 
Update our MSAL.NET dependency to 4.37 from 4.31. This should come with
the following updates/fixes that we care about:

- Can set embedded web view (legacy) window title to custom message
- Fixes some problems with WAM dialogs appearing behind parent windows
- Moves WAM to no longer being experimental
- Better MSA-PT support when used with WAM
- Numerous performance improvements with authority discovery
- Various WAM bug fixes

Fixes git-ecosystem#239
@mjcheetham mjcheetham mentioned this issue Nov 2, 2021
Merged
@mjcheetham
Copy link
Collaborator

PR #512 should allow us to set the window title on the embedded browser window, which once merged, will be in the next release.

This was referenced Nov 15, 2021
Merged
Merged
ldennington pushed a commit to ldennington/git-credential-manager that referenced this issue Jun 15, 2022
@mjcheetham @ldennington
msauth: update to MSAL.NET 4.37
9d4f908 
Update our MSAL.NET dependency to 4.37 from 4.31. This should come with
the following updates/fixes that we care about:

- Can set embedded web view (legacy) window title to custom message
- Fixes some problems with WAM dialogs appearing behind parent windows
- Moves WAM to no longer being experimental
- Better MSA-PT support when used with WAM
- Numerous performance improvements with authority discovery
- Various WAM bug fixes

Fixes git-ecosystem#239
imgbot bot pushed a commit to Jeverett3000/Git-Credential-Manager-Core that referenced this issue Nov 2, 2022
@mjcheetham @ImgBotApp
msauth: update to MSAL.NET 4.37
1d1fc4d 
Update our MSAL.NET dependency to 4.37 from 4.31. This should come with
the following updates/fixes that we care about:

- Can set embedded web view (legacy) window title to custom message
- Fixes some problems with WAM dialogs appearing behind parent windows
- Moves WAM to no longer being experimental
- Better MSA-PT support when used with WAM
- Numerous performance improvements with authority discovery
- Various WAM bug fixes

Fixes git-ecosystem#239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjcheetham mjcheetham

Labels
auth:microsoft Specific to Microsoft AAD/MSA authentication blocked Progress on this issue is blocked. enhancement New feature or request external Relating to an external partner, team, or library
Projects
None yet
Milestone
No milestone
4 participants
@vtbassmatt @mjcheetham @bgavrilMS @johnendev