Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get file store attr async to improve jgit startup performance #8

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

gzm55
Copy link
Contributor

@gzm55 gzm55 commented Apr 7, 2022

Let jgit calculate the file store attr async. In container environment, especially when .git dir and ~/.config/jgit locate on different volumes, jgit have to wait 3 seconds to fetch the file store attr before collect git repo info, and another 3 seconds in saver thread to write the attr into ~/.config/jgit.

In sync way, when we execute some short maven goals, such as mvn validate, the total time is less than 6 seconds, then maven exits with a dirty state in ~/.config/jgit, the config.lock and .probe-<UUID> file left there. After that the jgit will always fail to read or write to the default config file. With this pr, we can almost avoid this dirty state.

A releated jgit issue is here https://bugs.eclipse.org/bugs/show_bug.cgi?id=579445

Context

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@gzm55
Copy link
Contributor Author

gzm55 commented Apr 11, 2022

@TheSnoozer could you plz review this pr?

@TheSnoozer
Copy link
Contributor

Hi,
thanks for your contribution! Sorry for the delay in reviewing this...kinda busy....but oh well let me not waste any more time and click the MR button.

Thanks again!

@TheSnoozer TheSnoozer merged commit f056f93 into git-commit-id:master Apr 20, 2022
@gzm55
Copy link
Contributor Author

gzm55 commented Apr 21, 2022

Hi, thanks for your contribution! Sorry for the delay in reviewing this...kinda busy....but oh well let me not waste any more time and click the MR button.

Thanks again!

@TheSnoozer thanks for merging this pr. can we port back this little change to 4.10? cause we cannot move to JDK 11 in short time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants