Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#701: Fix an issue with submodules #705

Merged
merged 5 commits into from
Mar 4, 2024
Merged

#701: Fix an issue with submodules #705

merged 5 commits into from
Mar 4, 2024

Conversation

TheSnoozer
Copy link
Collaborator

Context

This MR fixes an issue with submodules (see #701)

Needed changes:

  • move the GitDirLocator from git-commit-id-maven-plugin to git-commit-id-plugin-core
  • extended the Callback with shouldFailOnNoGitDirectory that determines if the execution should fail if no git directory can be extracted (please note that build information might now be populated since it is unrelated to git data)

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer TheSnoozer added this to the 7.0.1 milestone Mar 2, 2024
@TheSnoozer TheSnoozer merged commit b6ad05e into master Mar 4, 2024
27 of 28 checks passed
@TheSnoozer TheSnoozer deleted the 701 branch March 4, 2024 19:36
@TheSnoozer TheSnoozer added the bug label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant