#531: session.getProjectDependencyGraph() might be null when running the plugin from eclipse
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2020 21:54
… a difference if we use @parameter(property = 'session', ...) VS a @parameter(defaultValue = '')
….getProjectDependencyGraph() might be null. Although the plugin is executed with maven's plugin prefix resolution ('pl.project13.maven:git-commit-id-plugin:4.0.1:revision:basepom.default:initialize') this seems to make it impossible to find out if this plugin was executed before. As a result it this patch might defeat the point of 'runOnlyOnce'.
TheSnoozer
force-pushed
the
issues-531
branch
from
a213edd to
1291c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B