Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reproducible builds by suppressing date comment in properties #502

Merged

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Jun 29, 2020

Context

The native java.util.Properties class in Java will add a comment in each properties file with the timestamp when the file was generated, which prevents projects implementing reproducible builds.

This change set replaces the usage of java.util.Properties and the custom order-preserving wrapper around it with the java-ordered-properties project, which prevents writing the timestamp comment and still retains a reproducible order in the properties files.

Fixes #472

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer
Copy link
Collaborator

Hi, sorry for the delay (again). Thanks for taking care of this and your contribution! Also a great shout-out for your contribution to etiennestuder/java-ordered-properties#4!

Changes look good to me. I'm going ahead and merge :-)

@TheSnoozer TheSnoozer merged commit 178bd88 into git-commit-id:master Jul 5, 2020
@TheSnoozer TheSnoozer added this to the 4.0.1 milestone Jul 5, 2020
@joschi joschi deleted the issue-472-reproducible-builds branch July 5, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent header timestamp in git.properties to allow for reproducible builds
2 participants