Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#413: use maven's PluginParameterExpressionEvaluator to allow replacements with values that contain unresolved variables #444

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

TheSnoozer
Copy link
Collaborator

@TheSnoozer TheSnoozer commented Oct 12, 2019

Context

See #413

Effectively allows:

<replacementProperties>
         <replacementProperty>
            <property>sonar.projectVersion</property>
            <token>^.*$</token>
            <value>${project.version}-${git.branch}</value>
            <regex>false</regex>
         </replacementProperty>
      </replacementProperties>

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

TheSnoozer added 2 commits October 12, 2019 22:00
…allow replacements with values that contain unresolved variables (maven sometimes just behaves weird)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant