Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #438 Populate "git.branch" and "git.build.number" for Azure DevOps #439

Merged

Conversation

dandragut
Copy link
Contributor

@dandragut dandragut commented Oct 2, 2019

Context

Populate "git.branch" and "git.build.number" for Azure DevOps

2019-10-01T09:20:52.8249155Z BUILD_BUILDNUMBER=20191001.1
2019-10-01T09:20:52.8249357Z BUILD_SOURCEBRANCHNAME=74902_build_info-and-pipelines_v3
...
2019-10-01T09:21:01.5141375Z [INFO] Collected git.build.number with value 20191001.1
...
2019-10-01T09:21:00.9696385Z [INFO] Using environment variable based branch name. BUILD_SOURCEBRANCHNAME = 74902_build_info-and-pipelines_v3
2019-10-01T09:21:00.9747110Z [INFO] Collected git.branch with value 74902_build_info-and-pipelines_v

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer
Copy link
Collaborator

Thank you for your contribution!

Based on you log message I assume you have tested your changes with a local version of the plugin and it seemed to have worked. The changes look good for me. I'm going ahead and merge this without any additional testing - at least travis does not complain so it should be fine.

Thanks again for your work on getting this plugin improved!

@TheSnoozer TheSnoozer merged commit d7ad0f8 into git-commit-id:master Oct 2, 2019
@TheSnoozer TheSnoozer added this to the 3.0.2 milestone Oct 2, 2019
@TheSnoozer TheSnoozer modified the milestones: 3.0.2, 4.0-modularized Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants