Fixes #410 / #185 / #403 / #415 #414

TheSnoozer · 2019-04-29T16:08:47Z

Context

see individual commits for references or:

Bamboo build number do not use the right case #410: Bamboo build variables do not use the right case
Instead of determine all properties and then exclude properties why not choose selective running (native git) #185: Instead of determine all properties and then exclude properties why not choose selective running
Setting evaluateOnCommit to any branch will only result in the commit-id instead of the branch name #403: Setting evaluateOnCommit to any branch will only result in the commit-id instead of the branch name
Expose the generated properties not only in project.properties #415: Expose the generated properties not only in project.properties
Skip git invocation if properties are already computed

…de properties why not choose selective running

…esult in the commit-id instead of the branch name

…branch and furthermore excludeProperties/includeOnlyProperties might now also havean effect on the overall plugin performance

…t.properties

In a multi-modules project, one can set injectAllReactorProjects to true to add all the properties to each reactor's project, but there's no automated effort to skip git execution if properties are already set unless runOnlyOnce is set to true. But runOnce has two issues itself: - it assumes that the top-level project is included in the reactor - it skips the whole plugin execution To address this, detect during plugin execution if properties from a previous project in the reactor have been already computed and added to the current project's context, and skip git execution if this is the case.

…395288044/.git/gc.log.lock and close repositories before deleting

TheSnoozer added 7 commits April 15, 2019 18:01

git-commit-id#410: Bamboo build variables do not use the right case

63d22fd

extract the generation of the properties file into a separate class

5f70fd4

git-commit-id#185: Instead of determine all properties and then exclu…

200986a

…de properties why not choose selective running

git-commit-id#403: Setting evaluateOnCommit to any branch will only r…

6df9d0b

…esult in the commit-id instead of the branch name

do not silently ignore exceptions & improve exception reporting

187ea2f

update docs and highlight that evaluateOnCommit has an effect on git.…

125c834

…branch and furthermore excludeProperties/includeOnlyProperties might now also havean effect on the overall plugin performance

fix checkstyle coding style definition

ef4f648

TheSnoozer mentioned this pull request Apr 29, 2019

Skip git invocation if properties are already computed #411

Closed

4 tasks

git-commit-id#415: Expose the generated properties not only in projec…

94e6990

…t.properties

TheSnoozer changed the title ~~Fixes #410 / #185 / #403~~ Fixes #410 / #185 / #403 / #415 Apr 30, 2019

TheSnoozer added this to the 3.0 milestone Apr 30, 2019

TheSnoozer added 5 commits April 30, 2019 16:58

avoid java.io.IOException: Could not delete file /tmp/junit3874954897…

dd128c0

…395288044/.git/gc.log.lock and close repositories before deleting

update com.google.guava:guava from 27.0.1-jre to 27.1-jre

ff82250

update org.apache.httpcomponents:httpclient from 4.5.6 to 4.5.8

c2e8244

update org.codehaus.plexus:plexus-utils (test) from 3.1.1 to 3.2.0

c55210d

update org.mockito:mockito-core (test) from 2.23.4 to 2.27.0

9582d7c

TheSnoozer mentioned this pull request Apr 30, 2019

'runOnlyOnce' coupled with Maven's --projects param makes plugin not run at all #387

Closed

TheSnoozer merged commit 9821efc into git-commit-id:master Apr 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #410 / #185 / #403 / #415 #414

Fixes #410 / #185 / #403 / #415 #414

TheSnoozer commented Apr 29, 2019 •

edited

Loading

Fixes #410 / #185 / #403 / #415 #414

Fixes #410 / #185 / #403 / #415 #414

Conversation

TheSnoozer commented Apr 29, 2019 • edited Loading

Context

TheSnoozer commented Apr 29, 2019 •

edited

Loading