common: update and simplify code #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laymonage
force-pushed
the
main
branch
2 times, most recently
from
3495ae3 to
5e47893
Compare
laymonage
requested changes
Feb 25, 2024
react/src/lib/Giscus.tsx
Outdated
Comment on lines
29
to
33
| if (!mounted) return null; | ||
|
|
||
| return ( | ||
| <giscus-widget | ||
| id={id} |
There was a problem hiding this comment.
Thanks, but this wraps the component in a fragment unnecessarily. I'd much prefer the old explicit return null.
There was a problem hiding this comment.
OK, I revert to old explicit return null in 7286aeb.
laymonage
force-pushed
the
render-after-mount
branch
2 times, most recently
from
ee8c05b to
cb13db3
Compare
laymonage
force-pushed
the
render-after-mount
branch
from
cb13db3 to
06a9bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and simplify code in
Giscus.tsxfile