Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSA 1.2.3.1 Algorithms : Space Complexity #2233 #2484

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Conversation

lvi131
Copy link
Contributor

@lvi131 lvi131 commented Sep 24, 2021


Description 📜

Added information about space complexity of algorithms and some examples with explanation.
Fixes #2233


Type of change 📝

  • Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

  • DSA

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸


@keywordlabeler keywordlabeler bot added documentation Improvements or additions to documentation DSA labels Sep 24, 2021
@lvi131
Copy link
Contributor Author

lvi131 commented Sep 24, 2021

@goelesha
Please review my PR.

@jaigora24
Copy link

/assign

@github-actions
Copy link

This issue has been assigned to @jaigora24!
It will become unassigned if it isn't closed within 12 days. A maintainer can also add the pinned label to prevent it from being unassigned.

@github-actions github-actions bot added the Assigned Assigned to some work label Sep 24, 2021
Copy link
Collaborator

@goelesha goelesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the name of the file to that mentioned in the issue.
Also, add the links from where you have taken references for writing this content.

@goelesha
Copy link
Collaborator

/assign

@jaigora24 Kindly share what kind of contribution will you be making?

@lvi131
Copy link
Contributor Author

lvi131 commented Sep 25, 2021

Rename the name of the file to that mentioned in the issue.
Also, add the links from where you have taken references for writing this content.

Currently the naming is DSA/1.2 Analysis of Algorithms/3. Space_Complexity/1.2.3.1_Space_Complexity.md
What should i rename it to ?

I have used notes and stuff, haven't used any direct references.

@jaigora24
Copy link

@goelesha I have already created a PR for review

#2742

@goelesha goelesha merged commit 43020ac into girlscript:DSA Sep 26, 2021
@goelesha
Copy link
Collaborator

Rename the name of the file to that mentioned in the issue.
Also, add the links from where you have taken references for writing this content.

Currently the naming is DSA/1.2 Analysis of Algorithms/3. Space_Complexity/1.2.3.1_Space_Complexity.md
What should i rename it to ?

I have used notes and stuff, haven't used any direct references.

If you have not used any references then i guess its good to go !!
Happy Contributing 👍

@goelesha goelesha assigned lvi131 and unassigned jaigora24 Sep 26, 2021
@lvi131
Copy link
Contributor Author

lvi131 commented Sep 26, 2021

@goelesha Thank You!

@lvi131 lvi131 deleted the DSA branch September 26, 2021 18:30
@lvi131 lvi131 restored the DSA branch September 30, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assigned Assigned to some work documentation Improvements or additions to documentation DSA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants