-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 11.2: Overloading Vararg Methods #2218 #2418
Conversation
Please review it @AkMo3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkMo3 pls look into it once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harsh-Chaudhary7,
Following are some review points, please make necessary changes -
- In the beginning write simple explanation about "varargs method", what it is.
- Write its Syntax separately, "Syntax Of Varargs"
- "Relation among Primitive Data Types", is written using HTML Lists, appears as raw, they are not recognized as lists.
- It will be good if you can also write about internal working functionality of varargs, means How JVM treats it during program execution.
- Also keep simple file name, remove Issue Id, topic number from filename. You can simply put it like "Overloading_Vararg_Methods.md"
|
I'll make the neccesary changes for the 3rd point but for the other 3 points there are already issues created and files are present there. So, do i have to include these points too? |
Then it's okay, you can proceed with 3rd point. Also take care of below point. |
</ul> | ||
|
||
|
||
So the output of this code snippet will be **_int varargs_**, because int is more specific than double and float. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this part as well, it is not appearing as int varargs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me now.
…verloading_Varargs_Methods.md
Looks fine to me now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya ig its fine
thanks @sumitaccess007 for reviw
Description 📜
Explanation of Method Overloading in Varargs #2218
Type of change 📝
Domain of Contribution 📊
Checklist ✅
Screenshots / Gif (Optional) 📸