Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 11.2: Overloading Vararg Methods #2218 #2418

Merged
5 commits merged into from
Sep 25, 2021
Merged

Java 11.2: Overloading Vararg Methods #2218 #2418

5 commits merged into from
Sep 25, 2021

Conversation

Harsh-Chaudhary7
Copy link
Contributor


Description 📜

Explanation of Method Overloading in Varargs #2218


Type of change 📝

  • Doc#umentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

  • Java_#Domain

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸


@Harsh-Chaudhary7
Copy link
Contributor Author

Please review it @AkMo3

@Harsh-Chaudhary7 Harsh-Chaudhary7 changed the title Java Java 11.2: Overloading Vararg Methods #2218 Sep 24, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture

Pls do the needful changes

@ghost
Copy link

ghost commented Sep 24, 2021

@AkMo3 pls look into it once

@Harsh-Chaudhary7
Copy link
Contributor Author

Capture

Pls do the needful changes

I am sorry i couldn't understand what changes are you asking me to do. Can you please elaborate a little?

Copy link
Contributor

@sumitaccess007 sumitaccess007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harsh-Chaudhary7,
Following are some review points, please make necessary changes -

  1. In the beginning write simple explanation about "varargs method", what it is.
  2. Write its Syntax separately, "Syntax Of Varargs"
  3. "Relation among Primitive Data Types", is written using HTML Lists, appears as raw, they are not recognized as lists.
  4. It will be good if you can also write about internal working functionality of varargs, means How JVM treats it during program execution.
  5. Also keep simple file name, remove Issue Id, topic number from filename. You can simply put it like "Overloading_Vararg_Methods.md"

@sumitaccess007
Copy link
Contributor

Capture
Pls do the needful changes

I am sorry i couldn't understand what changes are you asking me to do. Can you please elaborate a little?
@Harsh-Chaudhary7 - You are trying to create a Unordered List here using HTML List, but unfortunately they are not appearing as list, list tags are appearing along with relations between primitive data types.
You can use "-" to make them a Unordered List in .md file.

@Harsh-Chaudhary7
Copy link
Contributor Author

@Harsh-Chaudhary7,
Following are some review points, please make necessary changes -

  1. In the beginning write simple explanation about "varargs method", what it is.
  2. Write its Syntax separately, "Syntax Of Varargs"
  3. "Relation among Primitive Data Types", is written using HTML Lists, appears as raw, they are not recognized as lists.
  4. It will be good if you can also write about internal working functionality of varargs, means How JVM treats it during program execution.

I'll make the neccesary changes for the 3rd point but for the other 3 points there are already issues created and files are present there. So, do i have to include these points too?

@sumitaccess007
Copy link
Contributor

@Harsh-Chaudhary7,
Following are some review points, please make necessary changes -

  1. In the beginning write simple explanation about "varargs method", what it is.
  2. Write its Syntax separately, "Syntax Of Varargs"
  3. "Relation among Primitive Data Types", is written using HTML Lists, appears as raw, they are not recognized as lists.
  4. It will be good if you can also write about internal working functionality of varargs, means How JVM treats it during program execution.

I'll make the neccesary changes for the 3rd point but for the other 3 points there are already issues created and files are present there. So, do i have to include these points too?

Then it's okay, you can proceed with 3rd point. Also take care of below point.
Keep simple file name, remove Issue Id, topic number from filename. You can simply put it like "Overloading_Vararg_Methods.md"

</ul>


So the output of this code snippet will be **_int varargs_**, because int is more specific than double and float.
Copy link
Contributor

@sumitaccess007 sumitaccess007 Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this part as well, it is not appearing as int varargs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Anything else?

Copy link
Contributor

@sumitaccess007 sumitaccess007 Sep 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now.

@Harsh-Chaudhary7 Harsh-Chaudhary7 requested a review from a user September 24, 2021 15:42
@sumitaccess007
Copy link
Contributor

Looks fine to me now.
@garvitraj - Please have a final look.
Thanks

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya ig its fine
thanks @sumitaccess007 for reviw

@ghost ghost merged commit 7263d18 into girlscript:Java Sep 25, 2021
@ghost ghost added GWOC21 documentation Improvements or additions to documentation Java labels Sep 25, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation GWOC21 Java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants