Latest changes from Microsoft #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update sample driver with multimon support * Fix compiler warning Co-authored-by: Shantanu Gupta <[email protected]>
Update comments for SwapChainProcessor in IndirectDisplay driver sample Co-authored-by: Shantanu Gupta <[email protected]>
* Merged current inbox code except for DDKSPLIT * 19H1 inbox code except for DDKSPLIT and storport_p.h * Removed internal code
Data is pointer to array of HID_DATA structure. Function advances pointer as it packs the report buffer. At end of process the function attempts to go back through the buffer and update the IsDataSet member. What it's actually doing is writing unexpected memory locations. Fix is to store the head of the array and move back before walking again to set the bits.
* Fixed build errors when disabling sideband, * A note about the SysVAD sample and HLK testing.
Modify the inbound NBL's UDP port # to that of the original outbound traffic, in order to meet the inbound filter conditions
…#562) Followed the instruction to change the Algorithm to use SAH256 Right click on driver project in Visual Studio and select "Properties" Select Configuration: All Configurations and Platform: All Platforms Select "Driving Signing" from the Configuration Properties Enter sha256 for "File Digest Algorithm" Apply changes and exit Properties Save project
* Replace unsafe allocation API with ExAllocatePool2 * Fix for downlevel support. Co-authored-by: Drew Maczugowski <[email protected]>
Co-authored-by: Drew Maczugowski <[email protected]>
* replaces ExAllocatePoolWithTag to ExAllocatePoolZero * adds marco for downlevel support * removes unneeded change * changes comment to reflect new API usage * fixes alignment issues * changes spacing Co-authored-by: Elaine Houha <[email protected]>
Updated sample to remove deprecated API usage (ExAllocatePoolWithTag to ExAllocatePoolZero) Co-authored-by: Elaine Houha <[email protected]>
Changes a `NT_ASSERT` to match what the comment above is saying, the previous version caused a system crash if the packet was not inbound and had a auth decision made already.
The comment
` // Skip pended connections in the list, for which the auth decision is already taken.`
` // They should not be for inbound connections.`
to my understanding means inbound connections should be ignored and ignore connections for which the auth decision was already made. The latter is checked by:
` if (packet->authConnectDecision == 0)`
which keeps `found` equal to `FALSE` triggering the packet and list entry to be set to `NULL` here:
`if (!found)
{
listEntry = NULL;
packet = NULL;
}`
Change also updates the .sln and .vxproj files so the sample compiles on VS2019 without any changes - addressing #366
Co-authored-by: Elaine Houha <[email protected]>
Sets file digest algorithm for wdfserial and usbfx2 drivers to SHA256 https://dev.azure.com/microsoft/OS/_workitems/edit/31022366 https://dev.azure.com/microsoft/OS/_workitems/edit/31022410 **How Tested:** Compiling the two driver solutions shows they are correctly signed using SHA256
I looked at the commits of all the other projects that added sha256 to the driver sign and did a find and replace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.