-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR #20
Merged
Merged
PR #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The xml is not serialized according to the order specified in the autosar schema - Now, it's possible to properly generate the elements SwBaseType, CompuMethod etc. - Updated example with SwBaseType, CompuMethod, DataConstr creation - Added a new context menu action in the ui to copy the file path of the respective node
…t of elements in the xml node. Now, the file is properly serialized as expected by Autosar schema.
…visible model elements like BaseTypeDirectDefinition inside SwBaseType
…ow the tool is able to properly manage RoleWrapperElements and normal elements which is added as a list of containment elements. Added additional compu method in the example script for rational coeffs to see if the V are added as per the order
…girishchandranc/autosarfactory into 14-issue-with-xml-serialization
…tType inside Sdg. Added unit test and updated example script.
…or containtment elements
…geableElements) into a file
…s inherited from different levels.
… the referenced object has no short-name
…nce this was requested by many users)
…es which caused generation of some objects inconsistent
…hoice in the schema/ecore model
…was not respected
…pective autosar versions.
…r when elements are added to a list which are not Referrable)
… the elements are removed using the remove api. Also, fixed issue with reading of elements when there is only concrete sub type available in the autosar metamodel
Hi @christianhecht86 , |
…girishchandranc/autosarfactory into 14-issue-with-xml-serialization
@christianhecht86 The tests are also successful in the PR. I can merge to master once you approve the PR. |
christianhecht86
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Tests on my side are successful
Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issues wrt xml serialization.