Possible fix for #424 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeeren
previously approved these changes
Jun 12, 2020
| if eTag.IsSome then responseHeaders.ETag <- eTag.Value | ||
| if lastModified.IsSome then responseHeaders.LastModified <- Nullable(lastModified.Value) | ||
| if eTag.IsSome then responseHeaders.ETag <- eTag.Value | ||
| if lastModified.IsSome then responseHeaders.LastModified <- Nullable(lastModified.Value.CutOffMs()) |
There was a problem hiding this comment.
Not sure this has any effect, but I don't think there's any harm here either
TheAngryByrd
requested changes
Jun 12, 2020
| @@ -88,7 +89,8 @@ type HttpContext with | |||
| match lastModified with | |||
| | None -> AllConditionsMet | |||
| | Some lastModified -> | |||
| match requestHeaders.IfModifiedSince.Value <= DateTimeOffset.UtcNow | |||
| let lastModified = lastModified.CutOffMs() | |||
| match requestHeaders.IfModifiedSince.Value <= DateTimeOffset.UtcNow.CutOffMs() | |||
There was a problem hiding this comment.
Might need an integration test to check the value of requestHeaders.IfModifiedSince.Value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #424