Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mise à jour de Python vers 3.12 [GEN-2214] #5049

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

francoisfreitag
Copy link
Contributor

🤔 Pourquoi ?

Rester à jour, aller plus vite !

@francoisfreitag francoisfreitag added the no-changelog Ne doit pas figurer dans le journal des changements. label Nov 5, 2024
@francoisfreitag francoisfreitag self-assigned this Nov 5, 2024
@francoisfreitag francoisfreitag added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Nov 5, 2024
@francoisfreitag francoisfreitag force-pushed the ff/py312 branch 3 times, most recently from 1a4beb3 to 6e53885 Compare November 5, 2024 11:22
Otherwise, the default version from the environment is used. This issue
was revealed during the upgrade to Python 3.12, where the
NamedTemporaryFile.delete_on_close keyword argument did not exist.

Avoid surprises by using the same version of python as the rest of the
application.
@francoisfreitag francoisfreitag added tech and removed no-changelog Ne doit pas figurer dans le journal des changements. labels Nov 5, 2024
@francoisfreitag francoisfreitag changed the title Mise à jour de Python vers 3.12 Mise à jour de Python vers 3.12 [GEN-2214] Nov 5, 2024
Copy link

🏎️ Python 3.12

@francoisfreitag francoisfreitag added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels Nov 5, 2024
@francoisfreitag francoisfreitag removed the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Nov 5, 2024
@gip-inclusion gip-inclusion deleted a comment from github-actions bot Nov 5, 2024
@gip-inclusion gip-inclusion deleted a comment from github-actions bot Nov 5, 2024
@francoisfreitag francoisfreitag added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Nov 5, 2024
@@ -238,7 +238,6 @@
dict({
'origin': list([
'select_min_max_job_applications[siae_evaluations/models.py]',
'EvaluationCampaign.<listcomp>[siae_evaluations/models.py]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha je ne m'y attendais pas 😅

@@ -1,15 +1,11 @@
import datetime
import time
from itertools import batched
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien vu 👍

@@ -1627,6 +1627,12 @@ sentry-sdk==2.17.0 \
--hash=sha256:625955884b862cc58748920f9e21efdfb8e0d4f98cca4ab0d3918576d5b606ad \
--hash=sha256:dd0a05352b78ffeacced73a94e86f38b32e2eae15fff5f30ca5abb568a72eacf
# via -r requirements/test.txt
setuptools==75.3.0 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est normal qu'il revienne lui ?
il me semblait qu'il était parti au passage à uv

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonne question, et j’avais la réponse : setuptools n’est plus installé par défaut par virtualenv.

gh-95299: Do not pre-install setuptools in virtual environments created with venv. This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the activated virtual environment.

https://docs.python.org/3/whatsnew/3.12.html#ensurepip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il vient pour django-easymde.

@francoisfreitag francoisfreitag removed the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Nov 6, 2024
@francoisfreitag francoisfreitag added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 9b38b67 Nov 6, 2024
22 of 24 checks passed
@francoisfreitag francoisfreitag deleted the ff/py312 branch November 6, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants