#2363 - Réutiliser le même composant d'affichage de détail d'une convention #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
4 times, most recently
from
1aa1abb
to
23f3e51
Compare
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
4 times, most recently
from
c6fb16e
to
eb0d481
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
front/src/app/components/admin/conventions/ConventionValidationDetails.tsx
Fixed
Show fixed
Hide fixed
front/src/app/components/admin/conventions/ConventionValidationDetails.tsx
Fixed
Show fixed
Hide fixed
front/src/app/components/admin/conventions/ConventionValidationDetails.tsx
Fixed
Show fixed
Hide fixed
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
eb0d481
to
7209bb7
Compare
front/src/app/contents/convention/conventionSummary.helpers.tsx
Dismissed
Show dismissed
Hide dismissed
front/src/app/contents/convention/conventionSummary.helpers.tsx
Dismissed
Show dismissed
Hide dismissed
front/src/app/contents/convention/conventionSummary.helpers.tsx
Dismissed
Show dismissed
Hide dismissed
front/src/app/contents/convention/conventionSummary.helpers.tsx
Dismissed
Show dismissed
Hide dismissed
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
14 times, most recently
from
a9d4b57
to
99c6057
Compare
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
99c6057
to
3922c22
Compare
celineung
changed the title
JeromeBu
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
531fea8
to
017d3d8
Compare
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
017d3d8
to
6905837
Compare
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
6905837
to
f144e9f
Compare
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
f144e9f
to
8c9fd3e
Compare
JeromeBu
approved these changes
Nov 21, 2024
front/src/app/components/forms/convention/ConventionFormWrapper.tsx
Outdated
Show resolved
Hide resolved
front/src/app/components/forms/convention/ConventionSignForm.tsx
Outdated
Show resolved
Hide resolved
.../react-design-system/src/immersionFacile/components/convention-summary/ConventionSummary.tsx
Outdated
Show resolved
Hide resolved
enguerranws
approved these changes
Nov 21, 2024
|
|
||
| return ( | ||
| <> | ||
| <Badge |
There was a problem hiding this comment.
C'est dommage que l'info de statut soit à part du récap de convention, mais je vois pourquoi. On verra si on peut pas (via un changement d'UI) le rapatrier plus tard
front/src/app/components/admin/conventions/ConventionValidation.tsx
Outdated
Show resolved
Hide resolved
| ]} | ||
| /> | ||
| <div className={fr.cx("fr-accordions-group")}> | ||
| {route.name !== "conventionCustomAgency" && ( |
There was a problem hiding this comment.
Je me souviens plus ce qu'est conventionCustomAgency, mais on en a plus besoin ?
There was a problem hiding this comment.
vu avec Nathalie: on n'en a plus besoin
front/src/app/components/forms/convention/ConventionFormWrapper.tsx
Outdated
Show resolved
Hide resolved
front/src/app/contents/convention/conventionSummary.helpers.tsx
Outdated
Show resolved
Hide resolved
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
8c9fd3e
to
06b1970
Compare
celineung
force-pushed
the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
from
06b1970
to
7e2ea93
Compare
celineung
deleted the
2363-regrouper-les-pages-pilotage-dune-convention-et-vrification-dune-demande-de-convention-en-une-seule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈 Description
Redesign de la page d'affichage de la convention
💯 Pour tester
Utiliser la review-app pour vérifier le parcours utilisateur.
Sinon, pour un aperçu de ce que ça donne : https://if-dev-front-pr2465.osc-fr1.scalingo.io/api/to/tPd5nuiANeIv-6jNeoD425b-d1ctHAmbHysc
❓ Remarques
Il y a pas mal de suggestions du bot github ci-dessous qui impliquent l'ajout de nouvelles librairies.
Qu'en dites-vous ?