Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookies and crashes on webview #60

Merged
merged 3 commits into from
Mar 23, 2024
Merged

Fix cookies and crashes on webview #60

merged 3 commits into from
Mar 23, 2024

Conversation

inkeliz
Copy link
Contributor

@inkeliz inkeliz commented Mar 23, 2024

This changes fixes crashes on Windows (#59) and use secure-cookies when requested (on macOS).

@inkeliz inkeliz merged commit 3331d8c into main Mar 23, 2024
@gedw99
Copy link

gedw99 commented Apr 4, 2024

Nice one

I will try this on windows arm64 in UTM from my MAC

@gedw99
Copy link

gedw99 commented Apr 5, 2024

on windows 11 arm64 I got:

[0405/010811.835:ERROR:window_impl.cc(121)] Failed to unregister class Chrome_WidgetWin_0. Error = 0

it opened and then created a folder called "gio-plugin-webview_windows_arm64.exe.WebView2", since the binary is called "gio-plugin-webview_windows_arm64.exe".

working on what's up...

@gedw99
Copy link

gedw99 commented Apr 5, 2024

I installed WebView2 for Edge from https://go.microsoft.com/fwlink/p/?LinkId=2124703

same error ...

I installed directly from
https://developer.microsoft.com/en-gb/microsoft-edge/webview2/?form=MA13LH#download

same error ...

Shall I turn this into an issue ?
I can also install golang onto that instance and try it from there.
I make the binary on a Mac using "CGO_ENABLED=1 GOOS=windows GOARCH=arm64 go build"

@inkeliz
Copy link
Contributor Author

inkeliz commented Apr 5, 2024

"Failed to unregister class Chrome_WidgetWin_0. Error = 0" happens when close the app right?

@gedw99
Copy link

gedw99 commented Apr 5, 2024

hey @inkeliz

No it’s a different sequence occurring.

Here is the sequence:

I go to the terminal so I can see the log output and open it from there.

I execute the .exe and the gui opens and you see a white background.

then it creates a folder with various folders inside it relating to Webview2 I think.

then it crashes / closes and I can see the error output.

The output was pretty long. I only posted the final error message here in this issue..

—-

This happens with or without the WebView2 for Edge installed.

—-

If you want more information , do not hesitate to ask.

@gedw99
Copy link

gedw99 commented Apr 5, 2024

Btw it works fine on windows amd64. A buddy tested it for me.

so seems to be a windows 11 arm64 related bug.

I run on mac and use UTM to run windows 11 arm64 btw. Are you also on mac ?

@inkeliz
Copy link
Contributor Author

inkeliz commented Apr 5, 2024

Yes, I'm using mac (MacStudio M2). I never tested Windows on ARM64.

@gedw99
Copy link

gedw99 commented Apr 5, 2024

UTM is awesome

https://mac.getutm.app/gallery/windows-11-arm

@inkeliz inkeliz deleted the fix-webviewer-windows branch June 4, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants