Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comptability with Twig 3.9 #22

Open
majermi4 opened this issue May 6, 2024 · 3 comments
Open

Comptability with Twig 3.9 #22

majermi4 opened this issue May 6, 2024 · 3 comments

Comments

@majermi4
Copy link

majermi4 commented May 6, 2024

Hi, I've noticed that our app started failing after third-party libraries upgrade and I traced it to Twig library upgrade from 3.8 to 3.9.

I suspect it's something related to the twig components lexer?

@giorgiopogliani
Copy link
Owner

yeah, ours too I just pushed an update to limit twig dependency below 3.9

They changed the behaviour of nodes to use yield instead of echo for some reason I don't know yet.

giorgiopogliani added a commit that referenced this issue May 6, 2024
giorgiopogliani added a commit that referenced this issue Sep 12, 2024
* yield ready update #22

* update twig

* remove twig 2

* update php requirement

* update component render

* migrate configuration

* migrate configuration

* update phpunit
giorgiopogliani added a commit that referenced this issue Sep 12, 2024
@stuible
Copy link

stuible commented Sep 18, 2024

Hey, thanks for the incredible project, I've been a big fan of using it with Craft CMS! However, the latest version of Craft requires Twig 3.14.0 which is incompatible with Twig Components. Is there a timeline for releasing a version that is compatible? Anything I can help with?

@giorgiopogliani
Copy link
Owner

Hey! It seems that Twig had a bug at one point, and the absence of the YieldReady attribute wasn’t working properly and so I created the PR. Now, I’m using it with Craft 5 and Twig 3.14, and it seems to be working fine, I'm using dev-master, I am not encountering issues so I probably tag a new version.

Regarding the YieldReady situation, I’m not sure if it will become mandatory at some point, but when I tried to rewrite the echo statements with yield I encountered some problems, so at the moment it’s still a work in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants