Pp 948 help screen landscape #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
danicretu
approved these changes
Dec 20, 2024
obaidgini
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Looks good to me , but it is not working on my device with this branch, because it is not merged yet, we have lock portrait orientation in between onboarding and help screen that's why it is not working yet, but I can see the removal of lock portrait in onboarding landscape PR, so when these will be merged it will work, that's why approving
|
Closing the pull request as it is merged in #653 and 653 pull request will be merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landscape screens.
Added padding a little bit