Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(capture-sdk) Add landscape orientation for Error screen and N… #649

Closed
wants to merge 2 commits into from
Closed

feature(capture-sdk) Add landscape orientation for Error screen and N… #649

wants to merge 2 commits into from

Conversation

GeraltRiv
Copy link
Contributor

Error screen:

Portrait:
photo_2024-12-19 14 13 44

Landscape:
photo_2024-12-19 14 13 45
photo_2024-12-19 14 13 46

No results screen:

Portrait
photo_2024-12-19 14 13 42

Landscape:
photo_2024-12-19 14 13 41
photo_2024-12-19 14 13 39
photo_2024-12-19 14 13 49

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

danicretu
danicretu approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@GeraltRiv GeraltRiv self-assigned this Dec 20, 2024
obaidgini
obaidgini approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@obaidgini obaidgini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good me, un-used imports needs to be removed in future, and this is currently not working on device, because of force portrait mode, which will most probably work after merging because it is handled in onboarding landscape related PR.

@obaidgini
Copy link
Contributor

Closing the pull request as it is merged in #653 and this pull request will be merged to main.

@obaidgini obaidgini closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danicretu danicretu danicretu approved these changes

@obaidgini obaidgini obaidgini approved these changes

Assignees

@GeraltRiv GeraltRiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeraltRiv @obaidgini @danicretu