Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Arduino component name for ESP-IDF. #300

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

pvginkel
Copy link
Contributor

No description provided.

@pvginkel
Copy link
Contributor Author

The arduino component added as a dependency in ESP-IDF cannot be found. This is the compilation error:

CMake Error at C:/Users/pvgin/esp/v5.3.2/esp-idf/tools/cmake/build.cmake:268 (message):
  Failed to resolve component 'arduino'.
Call Stack (most recent call first):
  C:/Users/pvgin/esp/v5.3.2/esp-idf/tools/cmake/build.cmake:304 (__build_resolve_and_add_req)
  C:/Users/pvgin/esp/v5.3.2/esp-idf/tools/cmake/build.cmake:311 (__build_expand_requirements)
  C:/Users/pvgin/esp/v5.3.2/esp-idf/tools/cmake/build.cmake:607 (__build_expand_requirements)
  C:/Users/pvgin/esp/v5.3.2/esp-idf/tools/cmake/project.cmake:710 (idf_build_process)
  CMakeLists.txt:18 (project)

My idf_component.yml file looks like this:

dependencies:
  espressif/arduino-esp32:
    version: "*"
  FastAccelStepper:
    git: https://github.com/gin66/FastAccelStepper.git
    version: master

Changing the REQUIRES to arduino-esp32 fixes this issue.

Maybe I'm missing something obvious. @gagank1 do you have an idea whether this change is correct?

@gin66
Copy link
Owner

gin66 commented Dec 22, 2024

For espidf-compilation without arduino, I use platformio and not the espressif toolchain directly. Any chance to provide a github action, which actually tests espidf compilation without platformio ?

When using the library from ESP-IDF itself, the app sometimes hits a race condition where it reads _stepper from the StepperTask task before it's initialized. It's unclear why this happens when using ESP-IDF directly, and not when using Arduino.
@gin66 gin66 marked this pull request as ready for review December 24, 2024 13:56
@gin66 gin66 merged commit f9aa4fe into gin66:master Dec 24, 2024
55 checks passed
@pvginkel
Copy link
Contributor Author

Thank you for merging the PR. I'll take a stab at a GitHub action when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants