Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developed RMT support for Esp32s3 #225

Merged
merged 7 commits into from
Jan 13, 2024
Merged

Conversation

GarmischWg
Copy link
Contributor

  • Copied StepperISR_esp32c3_rmt.cpp to StepperISR_esp32s3_rmt.cpp
  • renamed registers at StepperISR_esp32s3_rmt.cpp
  • updated defines related to esp32s3 in fas_common.h
  • updated parts of readme related to esp32s3
  • find and replace "c3" to "s3" for the inline comments in StepperISR_esp32s3_rmt.cpp

Tested with 6 steppers only, with a shared enable pin.
I don't have 8 steppers.

Only line 2 in StepperISR_esp32_rmt.cpp is intentionally changed, the other changes is caused by the auto formatter.

@gin66
Copy link
Owner

gin66 commented Jan 12, 2024

Thanks for the PR.

Apparently the espressif lib has been updated and now causing a build error on github actions. I really need to fix it to a specific release in platformio.ini for all esp32 targets and not only some. And need to change the title in build_examples_esp32.yml

@GarmischWg
Copy link
Contributor Author

FYI, my setup:

  • platformio 6.1.13
  • esp32 idf: 6.4.0

for this setup, compilation was successful for esp32s3

@GarmischWg
Copy link
Contributor Author

From what i saw, it is just a warning, saying that a function in esp32-hal-uart.c should return bool instead of void. But we didn't write that function.... It is inside arduinoespressif32 framework. Is it possible to ignore that warning?

@gin66
Copy link
Owner

gin66 commented Jan 13, 2024

I will deal with it in a couple of days. for now I will just merge it, so you do not need to wait.

@gin66 gin66 merged commit 80392d0 into gin66:master Jan 13, 2024
11 of 14 checks passed
@GarmischWg
Copy link
Contributor Author

it is ok, i prefer that the development is not rushed, i can just use my local updated version of fastAccelLibrary first.

If people suddenly start raising issues about the new update, just revert it. (Hopefully this doesn't happen).

@gin66
Copy link
Owner

gin66 commented Jan 19, 2024

Your rmt driver is now included in 0.30.11. Thanks for the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants