-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developed RMT support for Esp32s3 #225
Conversation
Thanks for the PR. Apparently the espressif lib has been updated and now causing a build error on github actions. I really need to fix it to a specific release in platformio.ini for all esp32 targets and not only some. And need to change the title in build_examples_esp32.yml |
FYI, my setup:
for this setup, compilation was successful for esp32s3 |
From what i saw, it is just a warning, saying that a function in esp32-hal-uart.c should return bool instead of void. But we didn't write that function.... It is inside arduinoespressif32 framework. Is it possible to ignore that warning? |
I will deal with it in a couple of days. for now I will just merge it, so you do not need to wait. |
it is ok, i prefer that the development is not rushed, i can just use my local updated version of fastAccelLibrary first. If people suddenly start raising issues about the new update, just revert it. (Hopefully this doesn't happen). |
Your rmt driver is now included in 0.30.11. Thanks for the patch |
StepperISR_esp32c3_rmt.cpp
toStepperISR_esp32s3_rmt.cpp
StepperISR_esp32s3_rmt.cpp
fas_common.h
StepperISR_esp32s3_rmt.cpp
Tested with 6 steppers only, with a shared enable pin.
I don't have 8 steppers.
Only line 2 in
StepperISR_esp32_rmt.cpp
is intentionally changed, the other changes is caused by the auto formatter.